The active and suspend pin state of VSYNC is exactly the same, so just
use one node for both states.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi | 9 +--------
arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 11 ++---------
arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 2 +-
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts | 2 +-
4 files changed, 5 insertions(+), 19 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
index 63ab564655bc..a4dcc88bb01f 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
@@ -745,14 +745,7 @@ mdss_dsi_suspend: mdss-dsi-suspend-state {
bias-pull-down;
};
- mdss_te_active: mdss-te-active-state {
- pins = "gpio10";
- function = "mdp_vsync";
- drive-strength = <2>;
- bias-pull-down;
- };
-
- mdss_te_suspend: mdss-te-suspend-state {
+ mdss_te: mdss-te-state {
pins = "gpio10";
function = "mdp_vsync";
drive-strength = <2>;
diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
index 0386636a29f0..77ad613590a3 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi
@@ -247,7 +247,7 @@ &mdss_dsi0 {
pinctrl-names = "default", "sleep";
pinctrl-0 = <&mdss_dsi_default &mdss_te_default>;
- pinctrl-1 = <&mdss_dsi_sleep &mdss_te_sleep>;
+ pinctrl-1 = <&mdss_dsi_sleep &mdss_te_default>;
};
&mdss_dsi0_out {
@@ -730,14 +730,7 @@ mdss_dsi_sleep: mdss-dsi-sleep-state {
bias-pull-down;
};
- mdss_te_default: mdss-te-default-state {
- pins = "gpio10";
- function = "mdp_vsync";
- drive-strength = <2>;
- bias-pull-down;
- };
-
- mdss_te_sleep: mdss-te-sleep-state {
+ mdss_te_default: mdss-te-state {
pins = "gpio10";
function = "mdp_vsync";
drive-strength = <2>;
diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts
index 3c6a40212a8d..fd3a2121465b 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts
+++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts
@@ -104,7 +104,7 @@ &mdss_dsi0 {
pinctrl-names = "default", "sleep";
pinctrl-0 = <&mdss_dsi_default &mdss_te_default>;
- pinctrl-1 = <&mdss_dsi_sleep &mdss_te_sleep>;
+ pinctrl-1 = <&mdss_dsi_sleep &mdss_te_default>;
panel: panel@0 {
compatible = "jdi,fhd-r63452";
diff --git a/arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts b/arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts
index f8ab03f106a1..7e2ee9a4e9f0 100644
--- a/arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts
+++ b/arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts
@@ -51,7 +51,7 @@ &mdss_dsi0 {
pinctrl-names = "default", "sleep";
pinctrl-0 = <&mdss_dsi_default &mdss_te_default>;
- pinctrl-1 = <&mdss_dsi_sleep &mdss_te_sleep>;
+ pinctrl-1 = <&mdss_dsi_sleep &mdss_te_default>;
panel: panel@0 {
compatible = "jdi,fhd-r63452";
--
2.51.0
On 2/18/26 6:24 PM, Krzysztof Kozlowski wrote: > The active and suspend pin state of VSYNC is exactly the same, so just > use one node for both states. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
On Wed, Feb 18, 2026 at 06:24:23PM +0100, Krzysztof Kozlowski wrote:
> The active and suspend pin state of VSYNC is exactly the same, so just
> use one node for both states.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi | 9 +--------
> arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 11 ++---------
> arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 2 +-
> arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts | 2 +-
> 4 files changed, 5 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> index 63ab564655bc..a4dcc88bb01f 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> @@ -745,14 +745,7 @@ mdss_dsi_suspend: mdss-dsi-suspend-state {
> bias-pull-down;
> };
>
> - mdss_te_active: mdss-te-active-state {
> - pins = "gpio10";
> - function = "mdp_vsync";
> - drive-strength = <2>;
> - bias-pull-down;
> - };
> -
> - mdss_te_suspend: mdss-te-suspend-state {
> + mdss_te: mdss-te-state {
This is not used and probably can be dropped.
> pins = "gpio10";
> function = "mdp_vsync";
> drive-strength = <2>;
The rest LGTM.
--
With best wishes
Dmitry
On 19/02/2026 07:49, Dmitry Baryshkov wrote:
> On Wed, Feb 18, 2026 at 06:24:23PM +0100, Krzysztof Kozlowski wrote:
>> The active and suspend pin state of VSYNC is exactly the same, so just
>> use one node for both states.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi | 9 +--------
>> arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 11 ++---------
>> arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 2 +-
>> arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts | 2 +-
>> 4 files changed, 5 insertions(+), 19 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
>> index 63ab564655bc..a4dcc88bb01f 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
>> @@ -745,14 +745,7 @@ mdss_dsi_suspend: mdss-dsi-suspend-state {
>> bias-pull-down;
>> };
>>
>> - mdss_te_active: mdss-te-active-state {
>> - pins = "gpio10";
>> - function = "mdp_vsync";
>> - drive-strength = <2>;
>> - bias-pull-down;
>> - };
>> -
>> - mdss_te_suspend: mdss-te-suspend-state {
>> + mdss_te: mdss-te-state {
>
> This is not used and probably can be dropped.
>
But I think it should be used - it's just incomplete. There DSI is
enabled so there should be a panel using the TE/VSYNC. This looks like
being added for future, just like many other pincfg states.
Best regards,
Krzysztof
On Thu, Feb 19, 2026 at 08:23:45AM +0100, Krzysztof Kozlowski wrote:
> On 19/02/2026 07:49, Dmitry Baryshkov wrote:
> > On Wed, Feb 18, 2026 at 06:24:23PM +0100, Krzysztof Kozlowski wrote:
> >> The active and suspend pin state of VSYNC is exactly the same, so just
> >> use one node for both states.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> >> ---
> >> arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi | 9 +--------
> >> arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi | 11 ++---------
> >> arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 2 +-
> >> arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts | 2 +-
> >> 4 files changed, 5 insertions(+), 19 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> >> index 63ab564655bc..a4dcc88bb01f 100644
> >> --- a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi
> >> @@ -745,14 +745,7 @@ mdss_dsi_suspend: mdss-dsi-suspend-state {
> >> bias-pull-down;
> >> };
> >>
> >> - mdss_te_active: mdss-te-active-state {
> >> - pins = "gpio10";
> >> - function = "mdp_vsync";
> >> - drive-strength = <2>;
> >> - bias-pull-down;
> >> - };
> >> -
> >> - mdss_te_suspend: mdss-te-suspend-state {
> >> + mdss_te: mdss-te-state {
> >
> > This is not used and probably can be dropped.
> >
>
> But I think it should be used - it's just incomplete. There DSI is
> enabled so there should be a panel using the TE/VSYNC. This looks like
> being added for future, just like many other pincfg states.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
© 2016 - 2026 Red Hat, Inc.