[PATCH 2/8] dt-bindings: dma: nvidia,tegra186-gpc-dma: Make reset optional

Akhil R posted 8 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH 2/8] dt-bindings: dma: nvidia,tegra186-gpc-dma: Make reset optional
Posted by Akhil R 1 month, 2 weeks ago
In Tegra264 and Tegra234, GPCDMA reset control is not exposed to Linux
and is handled by BPMP. In Tegra234 BPMP supported a dummy reset which
just return success on reset without doing an actual reset. This as well
is not supported in Tegra264 BPMP. Therefore mark 'reset' and 'reset-names'
property as required only for devices prior to Tegra234.

Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
---
 .../bindings/dma/nvidia,tegra186-gpc-dma.yaml | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
index 542e9cb9f641..9457d406428f 100644
--- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
@@ -16,9 +16,6 @@ maintainers:
   - Rajesh Gumasta <rgumasta@nvidia.com>
   - Akhil R <akhilrajeev@nvidia.com>
 
-allOf:
-  - $ref: dma-controller.yaml#
-
 properties:
   compatible:
     oneOf:
@@ -68,12 +65,24 @@ required:
   - compatible
   - reg
   - interrupts
-  - resets
-  - reset-names
   - "#dma-cells"
   - iommus
   - dma-channel-mask
 
+allOf:
+  - $ref: dma-controller.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - nvidia,tegra186-gpcdma
+              - nvidia,tegra194-gpcdma
+      then:
+        required:
+          - resets
+          - reset-names
+
 additionalProperties: false
 
 examples:
-- 
2.50.1
Re: [PATCH 2/8] dt-bindings: dma: nvidia,tegra186-gpc-dma: Make reset optional
Posted by Rob Herring (Arm) 1 month, 2 weeks ago
On Tue, 17 Feb 2026 23:04:51 +0530, Akhil R wrote:
> In Tegra264 and Tegra234, GPCDMA reset control is not exposed to Linux
> and is handled by BPMP. In Tegra234 BPMP supported a dummy reset which
> just return success on reset without doing an actual reset. This as well
> is not supported in Tegra264 BPMP. Therefore mark 'reset' and 'reset-names'
> property as required only for devices prior to Tegra234.
> 
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
>  .../bindings/dma/nvidia,tegra186-gpc-dma.yaml | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml: allOf:1: 'then' is a dependency of 'if'
	hint: Keywords must be a subset of known json-schema keywords
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml: allOf:1:if: 'if' is a dependency of 'then'
	hint: Keywords must be a subset of known json-schema keywords
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260217173457.18628-3-akhilrajeev@nvidia.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.