[PATCH] drm/panel: simple: Correct G190EAN01 prepare timing

Ian Ray posted 1 patch 1 month, 2 weeks ago
drivers/gpu/drm/panel/panel-simple.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] drm/panel: simple: Correct G190EAN01 prepare timing
Posted by Ian Ray 1 month, 2 weeks ago
From: Sebastian Reichel <sebastian.reichel@collabora.com>

The prepare timing specified by the G190EAN01 datasheet should be
between 30 and 50 ms. Considering it might take some time for the
LVDS encoder to enable the signal, we should only wait the min.
required time in the panel driver and not the max. allowed time.

Fixes: 2f7b832fc992 ("drm/panel: simple: Add support for AUO G190EAN01 panel")
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 91ab280869ba..a242ae284db5 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1295,7 +1295,7 @@ static const struct panel_desc auo_g190ean01 = {
 		.height = 301,
 	},
 	.delay = {
-		.prepare = 50,
+		.prepare = 30,
 		.enable = 200,
 		.disable = 110,
 		.unprepare = 1000,
-- 
2.49.0
Re: [PATCH] drm/panel: simple: Correct G190EAN01 prepare timing
Posted by Neil Armstrong 1 week ago
Hi,

On Tue, 17 Feb 2026 16:25:26 +0200, Ian Ray wrote:
> The prepare timing specified by the G190EAN01 datasheet should be
> between 30 and 50 ms. Considering it might take some time for the
> LVDS encoder to enable the signal, we should only wait the min.
> required time in the panel driver and not the max. allowed time.
> 
> 

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/1] drm/panel: simple: Correct G190EAN01 prepare timing
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/f1080f82570b797598c1ba7e9c800ae9e94aafc6

-- 
Neil
Re: [PATCH] drm/panel: simple: Correct G190EAN01 prepare timing
Posted by Neil Armstrong 4 weeks, 1 day ago
On 2/17/26 15:25, Ian Ray wrote:
> From: Sebastian Reichel <sebastian.reichel@collabora.com>
> 
> The prepare timing specified by the G190EAN01 datasheet should be
> between 30 and 50 ms. Considering it might take some time for the
> LVDS encoder to enable the signal, we should only wait the min.
> required time in the panel driver and not the max. allowed time.
> 
> Fixes: 2f7b832fc992 ("drm/panel: simple: Add support for AUO G190EAN01 panel")
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>
> ---
>   drivers/gpu/drm/panel/panel-simple.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 91ab280869ba..a242ae284db5 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1295,7 +1295,7 @@ static const struct panel_desc auo_g190ean01 = {
>   		.height = 301,
>   	},
>   	.delay = {
> -		.prepare = 50,
> +		.prepare = 30,
>   		.enable = 200,
>   		.disable = 110,
>   		.unprepare = 1000,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil