[RFT PATCH v2 0/2] drm/panel: sitronix-st7789v: Convert to mipi_dbi

Chen-Yu Tsai posted 2 patches 1 month, 2 weeks ago
drivers/gpu/drm/drm_mipi_dbi.c                |   4 +-
drivers/gpu/drm/panel/Kconfig                 |   1 +
.../gpu/drm/panel/panel-sitronix-st7789v.c    | 306 +++++++-----------
include/drm/drm_mipi_dbi.h                    |   9 +
4 files changed, 121 insertions(+), 199 deletions(-)
[RFT PATCH v2 0/2] drm/panel: sitronix-st7789v: Convert to mipi_dbi
Posted by Chen-Yu Tsai 1 month, 2 weeks ago
Hi folks,

This small series converts the st7789v panel to use the mipi-dbi helpers
for register access.

Originally I intended to also add tinydrm support. My purpose was just
to test a TFT module that is on the Avaota A1 board. Archit is interested
in working on this driver, and I already used his/her previous patch to
check that my TFT was sort of working, albeit probably with the wrong
internal parameters. So this series will serve as a base for that work.

Patch 1 adds an option to invert the reset GPIO logic in the mipi-dbi
helpers. The reset logic originally assumes "high" is out of reset,
so an "enable" GPIO rather than a "reset" GPIO. However the st7789v
drivers assumes the proper "reset" GPIO logic.

Patch 2 converts all SPI register accesses in the st7789v to use the
mipi_dbi helpers. This actually reduces the number of function calls,
as the command and data portions of each message are combined. This
conversion also lets the driver support 8-bit plus D/C GPIO transfers.


This series is unfortunately only compile tested, as I do not have an
st7789v panel that is wired up for RGB input. So please help test the
changes.


Thanks
ChenYu

Changes since v1:
- Fix compile error from half changed reset GPIO handling 

Chen-Yu Tsai (2):
  drm/mipi-dbi: Provide option to invert reset GPIO logic
  drm/panel: sitronix-st7789v: Convert to mipi_dbi

 drivers/gpu/drm/drm_mipi_dbi.c                |   4 +-
 drivers/gpu/drm/panel/Kconfig                 |   1 +
 .../gpu/drm/panel/panel-sitronix-st7789v.c    | 306 +++++++-----------
 include/drm/drm_mipi_dbi.h                    |   9 +
 4 files changed, 121 insertions(+), 199 deletions(-)

-- 
2.47.3
Re: [RFT PATCH v2 0/2] drm/panel: sitronix-st7789v: Convert to mipi_dbi
Posted by Archit Anant 1 month, 1 week ago
On Tue, Feb 17, 2026 at 2:57 PM Chen-Yu Tsai <wens@kernel.org> wrote:
>
> Hi folks,
>
> This small series converts the st7789v panel to use the mipi-dbi helpers
> for register access.
>
> Originally I intended to also add tinydrm support. My purpose was just
> to test a TFT module that is on the Avaota A1 board. Archit is interested
> in working on this driver, and I already used his/her previous patch to
> check that my TFT was sort of working, albeit probably with the wrong
> internal parameters. So this series will serve as a base for that work.
>
> Patch 1 adds an option to invert the reset GPIO logic in the mipi-dbi
> helpers. The reset logic originally assumes "high" is out of reset,
> so an "enable" GPIO rather than a "reset" GPIO. However the st7789v
> drivers assumes the proper "reset" GPIO logic.
>
> Patch 2 converts all SPI register accesses in the st7789v to use the
> mipi_dbi helpers. This actually reduces the number of function calls,
> as the command and data portions of each message are combined. This
> conversion also lets the driver support 8-bit plus D/C GPIO transfers.
>
>
> This series is unfortunately only compile tested, as I do not have an
> st7789v panel that is wired up for RGB input. So please help test the
> changes.
>
>
> Thanks
> ChenYu
>

Hi ChenYu,

Thank you for sharing the series.

I’ll focus on completing the transition to the mipi_dbi helpers,
ensuring the reset
handling works correctly with the optional logic inversion, and updating
st7789v_check_id() to use ST7789V_IDS_SIZE and sizeof(ids) as discussed.

Although I don’t have access to the hardware, I’ll make sure the series builds
cleanly and review the changes carefully. I’ll also verify that the
8-bit SPI + D/C
GPIO configuration is handled correctly at the driver level.

--
Sincerely,
Archit Anant