[PATCH] media: venus: fix QCOM_MDT_LOADER dependency

Arnd Bergmann posted 1 patch 1 month ago
drivers/media/platform/qcom/venus/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] media: venus: fix QCOM_MDT_LOADER dependency
Posted by Arnd Bergmann 1 month ago
From: Arnd Bergmann <arnd@arndb.de>

When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_VENUS=y,
the kernel fails to link:

x86_64-linux-ld: drivers/media/platform/qcom/venus/firmware.o: in function `venus_boot':
firmware.c:(.text+0x1e3): undefined reference to `qcom_mdt_get_size'
firmware.c:(.text+0x25a): undefined reference to `qcom_mdt_load'
firmware.c:(.text+0x272): undefined reference to `qcom_mdt_load_no_init'

The problem is the conditional 'select' statement. Change this to
make the driver built-in here regardless of CONFIG_ARCH_QCOM,
same as for the similar IRIS driver.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
See https://patchwork.linuxtv.org/project/linux-media/patch/20260205145623.1360105-1-arnd@kernel.org/
for the corresponding iris patch I sent earlier
---
 drivers/media/platform/qcom/venus/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/venus/Kconfig b/drivers/media/platform/qcom/venus/Kconfig
index 164491c5c374..075e08eaceda 100644
--- a/drivers/media/platform/qcom/venus/Kconfig
+++ b/drivers/media/platform/qcom/venus/Kconfig
@@ -6,7 +6,7 @@ config VIDEO_QCOM_VENUS
 	depends on ZONE_DMA
 	select DMA_MASK_31 # technically 0xdfffffff
 	select OF_DYNAMIC if ARCH_QCOM
-	select QCOM_MDT_LOADER if ARCH_QCOM
+	select QCOM_MDT_LOADER
 	select QCOM_SCM
 	select VIDEOBUF2_DMA_CONTIG
 	select V4L2_MEM2MEM_DEV
-- 
2.39.5
Re: [PATCH] media: venus: fix QCOM_MDT_LOADER dependency
Posted by Dikshita Agarwal 2 weeks, 2 days ago

On 2/16/2026 5:45 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_VENUS=y,
> the kernel fails to link:
> 
> x86_64-linux-ld: drivers/media/platform/qcom/venus/firmware.o: in function `venus_boot':
> firmware.c:(.text+0x1e3): undefined reference to `qcom_mdt_get_size'
> firmware.c:(.text+0x25a): undefined reference to `qcom_mdt_load'
> firmware.c:(.text+0x272): undefined reference to `qcom_mdt_load_no_init'
> 
> The problem is the conditional 'select' statement. Change this to
> make the driver built-in here regardless of CONFIG_ARCH_QCOM,
> same as for the similar IRIS driver.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> See https://patchwork.linuxtv.org/project/linux-media/patch/20260205145623.1360105-1-arnd@kernel.org/
> for the corresponding iris patch I sent earlier
> ---
>  drivers/media/platform/qcom/venus/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/venus/Kconfig b/drivers/media/platform/qcom/venus/Kconfig
> index 164491c5c374..075e08eaceda 100644
> --- a/drivers/media/platform/qcom/venus/Kconfig
> +++ b/drivers/media/platform/qcom/venus/Kconfig
> @@ -6,7 +6,7 @@ config VIDEO_QCOM_VENUS
>  	depends on ZONE_DMA
>  	select DMA_MASK_31 # technically 0xdfffffff
>  	select OF_DYNAMIC if ARCH_QCOM
> -	select QCOM_MDT_LOADER if ARCH_QCOM
> +	select QCOM_MDT_LOADER
>  	select QCOM_SCM
>  	select VIDEOBUF2_DMA_CONTIG
>  	select V4L2_MEM2MEM_DEV

Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>

Thanks,
Dikshita
Re: [PATCH] media: venus: fix QCOM_MDT_LOADER dependency
Posted by Konrad Dybcio 1 month ago
On 2/16/26 1:15 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_VENUS=y,
> the kernel fails to link:
> 
> x86_64-linux-ld: drivers/media/platform/qcom/venus/firmware.o: in function `venus_boot':
> firmware.c:(.text+0x1e3): undefined reference to `qcom_mdt_get_size'
> firmware.c:(.text+0x25a): undefined reference to `qcom_mdt_load'
> firmware.c:(.text+0x272): undefined reference to `qcom_mdt_load_no_init'
> 
> The problem is the conditional 'select' statement. Change this to
> make the driver built-in here regardless of CONFIG_ARCH_QCOM,
> same as for the similar IRIS driver.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad