[PATCH] leds: ktd2692: Make ktd2692_timing variable static

Krzysztof Kozlowski posted 1 patch 1 month ago
drivers/leds/flash/leds-ktd2692.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] leds: ktd2692: Make ktd2692_timing variable static
Posted by Krzysztof Kozlowski 1 month ago
File-scope 'ktd2692_timing' is not used outside of this unit, so make it
static to silence sparse warning:

  leds-ktd2692.c:62:33: warning: symbol 'ktd2692_timing' was not declared. Should it be static?

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/leds/flash/leds-ktd2692.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/flash/leds-ktd2692.c b/drivers/leds/flash/leds-ktd2692.c
index 0f16eefcfe4c..22fbfccd4873 100644
--- a/drivers/leds/flash/leds-ktd2692.c
+++ b/drivers/leds/flash/leds-ktd2692.c
@@ -59,7 +59,7 @@ struct ktd2692_led_config_data {
 	enum led_brightness max_brightness;
 };
 
-const struct expresswire_timing ktd2692_timing = {
+static const struct expresswire_timing ktd2692_timing = {
 	.poweroff_us = 700,
 	.data_start_us = 10,
 	.end_of_data_low_us = 10,
-- 
2.51.0
Re: (subset) [PATCH] leds: ktd2692: Make ktd2692_timing variable static
Posted by Lee Jones 1 week, 5 days ago
On Mon, 16 Feb 2026 12:04:42 +0100, Krzysztof Kozlowski wrote:
> File-scope 'ktd2692_timing' is not used outside of this unit, so make it
> static to silence sparse warning:
> 
>   leds-ktd2692.c:62:33: warning: symbol 'ktd2692_timing' was not declared. Should it be static?
> 
> 

Applied, thanks!

[1/1] leds: ktd2692: Make ktd2692_timing variable static
      commit: c8193157eacb6c5e04f2f8aa45c17a05f1fc502f

--
Lee Jones [李琼斯]