i2c: npcm7xx: Use NULL instead of 0 for pointer

[PATCH] i2c: npcm7xx: Use NULL instead of 0 for pointer

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

Pointers should use NULL instead of explicit '0', as pointed out by
sparse:

  i2c-npcm7xx.c:1387:61: warning: Using plain integer as NULL pointer

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/i2c/busses/i2c-npcm7xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c
index 8b7e15240fb0..f667a873b81e 100644
--- a/drivers/i2c/busses/i2c-npcm7xx.c
+++ b/drivers/i2c/busses/i2c-npcm7xx.c
@@ -1384,7 +1384,7 @@ static irqreturn_t npcm_i2c_int_slave_handler(struct npcm_i2c *bus)
 		 */
 		bus->operation = I2C_NO_OPER;
 		bus->own_slave_addr = 0xFF;
-		i2c_slave_event(bus->slave, I2C_SLAVE_STOP, 0);
+		i2c_slave_event(bus->slave, I2C_SLAVE_STOP, NULL);
 		iowrite8(NPCM_I2CST_SLVSTP, bus->reg + NPCM_I2CST);
 		if (bus->fifo_use) {
 			npcm_i2c_clear_fifo_int(bus);
-- 
2.51.0

Re: [PATCH] i2c: npcm7xx: Use NULL instead of 0 for pointer

Posted by Andi Shyti 2 weeks ago

Hi Krzysztof,

On Mon, Feb 16, 2026 at 09:58:26AM +0100, Krzysztof Kozlowski wrote:
> Pointers should use NULL instead of explicit '0', as pointed out by
> sparse:
> 
>   i2c-npcm7xx.c:1387:61: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

merged to i2c/i2c-host.

Thanks,
Andi

Re: [PATCH] i2c: npcm7xx: Use NULL instead of 0 for pointer

Posted by Paul Menzel 1 month, 2 weeks ago

Dear Krzysztof,


Thank you for your patch.

Am 16.02.26 um 09:58 schrieb Krzysztof Kozlowski:
> Pointers should use NULL instead of explicit '0', as pointed out by
> sparse:
> 
>    i2c-npcm7xx.c:1387:61: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>   drivers/i2c/busses/i2c-npcm7xx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c
> index 8b7e15240fb0..f667a873b81e 100644
> --- a/drivers/i2c/busses/i2c-npcm7xx.c
> +++ b/drivers/i2c/busses/i2c-npcm7xx.c
> @@ -1384,7 +1384,7 @@ static irqreturn_t npcm_i2c_int_slave_handler(struct npcm_i2c *bus)
>   		 */
>   		bus->operation = I2C_NO_OPER;
>   		bus->own_slave_addr = 0xFF;
> -		i2c_slave_event(bus->slave, I2C_SLAVE_STOP, 0);
> +		i2c_slave_event(bus->slave, I2C_SLAVE_STOP, NULL);
>   		iowrite8(NPCM_I2CST_SLVSTP, bus->reg + NPCM_I2CST);
>   		if (bus->fifo_use) {
>   			npcm_i2c_clear_fifo_int(bus);

Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul