[PATCH] firmware: imx: sm-misc: Make scmi_imx_misc_ctrl_nb variable static

Krzysztof Kozlowski posted 1 patch 1 month, 2 weeks ago
drivers/firmware/imx/sm-misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] firmware: imx: sm-misc: Make scmi_imx_misc_ctrl_nb variable static
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
File-scope 'scmi_imx_misc_ctrl_nb' is not used outside of this unit, so
make it static to silence sparse warning:

  sm-misc.c:19:23: warning: symbol 'scmi_imx_misc_ctrl_nb' was not declared. Should it be static?

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/firmware/imx/sm-misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/imx/sm-misc.c b/drivers/firmware/imx/sm-misc.c
index 0a8ada329c9d..8d95a901734a 100644
--- a/drivers/firmware/imx/sm-misc.c
+++ b/drivers/firmware/imx/sm-misc.c
@@ -16,7 +16,7 @@
 
 static const struct scmi_imx_misc_proto_ops *imx_misc_ctrl_ops;
 static struct scmi_protocol_handle *ph;
-struct notifier_block scmi_imx_misc_ctrl_nb;
+static struct notifier_block scmi_imx_misc_ctrl_nb;
 
 int scmi_imx_misc_ctrl_set(u32 id, u32 val)
 {
-- 
2.51.0
Re: [PATCH] firmware: imx: sm-misc: Make scmi_imx_misc_ctrl_nb variable static
Posted by Daniel Baluta 1 month, 2 weeks ago
On Mon, Feb 16, 2026 at 10:23 AM Krzysztof Kozlowski
<krzysztof.kozlowski@oss.qualcomm.com> wrote:
>
> File-scope 'scmi_imx_misc_ctrl_nb' is not used outside of this unit, so
> make it static to silence sparse warning:
>
>   sm-misc.c:19:23: warning: symbol 'scmi_imx_misc_ctrl_nb' was not declared. Should it be static?
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>