drm/panel: mantix: Drop the shutdown callback

[PATCH] drm/panel: mantix: Drop the shutdown callback

Posted by Sebastian Krzyszkowiak 2 weeks, 2 days ago

It's the responsibility of the DRM modeset driver to unprepare
and disable the panel. Doing so here leads to regulator underflows.

Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
---
 drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
index 13352cb4ad77..02e203e9f41a 100644
--- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
+++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
@@ -295,20 +295,10 @@ static int mantix_probe(struct mipi_dsi_device *dsi)
 	return 0;
 }
 
-static void mantix_shutdown(struct mipi_dsi_device *dsi)
-{
-	struct mantix *ctx = mipi_dsi_get_drvdata(dsi);
-
-	drm_panel_unprepare(&ctx->panel);
-	drm_panel_disable(&ctx->panel);
-}
-
 static void mantix_remove(struct mipi_dsi_device *dsi)
 {
 	struct mantix *ctx = mipi_dsi_get_drvdata(dsi);
 
-	mantix_shutdown(dsi);
-
 	mipi_dsi_detach(dsi);
 	drm_panel_remove(&ctx->panel);
 }
@@ -323,7 +313,6 @@ MODULE_DEVICE_TABLE(of, mantix_of_match);
 static struct mipi_dsi_driver mantix_driver = {
 	.probe	= mantix_probe,
 	.remove = mantix_remove,
-	.shutdown = mantix_shutdown,
 	.driver = {
 		.name = DRV_NAME,
 		.of_match_table = mantix_of_match,

---
base-commit: 0f2acd3148e0ef42bdacbd477f90e8533f96b2ac
change-id: 20260216-mantix-shutdown-bf8d0a6457c7

Best regards,
-- 
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>

Re: [PATCH] drm/panel: mantix: Drop the shutdown callback

Posted by Neil Armstrong 12 hours ago

On 2/16/26 18:50, Sebastian Krzyszkowiak wrote:
> It's the responsibility of the DRM modeset driver to unprepare
> and disable the panel. Doing so here leads to regulator underflows.
> 
> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> ---
>   drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 11 -----------
>   1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> index 13352cb4ad77..02e203e9f41a 100644
> --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> @@ -295,20 +295,10 @@ static int mantix_probe(struct mipi_dsi_device *dsi)
>   	return 0;
>   }
>   
> -static void mantix_shutdown(struct mipi_dsi_device *dsi)
> -{
> -	struct mantix *ctx = mipi_dsi_get_drvdata(dsi);
> -
> -	drm_panel_unprepare(&ctx->panel);
> -	drm_panel_disable(&ctx->panel);
> -}
> -
>   static void mantix_remove(struct mipi_dsi_device *dsi)
>   {
>   	struct mantix *ctx = mipi_dsi_get_drvdata(dsi);
>   
> -	mantix_shutdown(dsi);
> -
>   	mipi_dsi_detach(dsi);
>   	drm_panel_remove(&ctx->panel);
>   }
> @@ -323,7 +313,6 @@ MODULE_DEVICE_TABLE(of, mantix_of_match);
>   static struct mipi_dsi_driver mantix_driver = {
>   	.probe	= mantix_probe,
>   	.remove = mantix_remove,
> -	.shutdown = mantix_shutdown,
>   	.driver = {
>   		.name = DRV_NAME,
>   		.of_match_table = mantix_of_match,
> 
> ---
> base-commit: 0f2acd3148e0ef42bdacbd477f90e8533f96b2ac
> change-id: 20260216-mantix-shutdown-bf8d0a6457c7
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil