[PATCH v2 5/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4088

Antoniu Miclaus posted 6 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH v2 5/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4088
Posted by Antoniu Miclaus 1 month, 2 weeks ago
Add device tree binding support for the AD4088 14-bit SAR ADC.
Add adi,ad4088 to the compatible enum.

A fallback compatible string to adi,ad4080 is not appropriate as the
AD4088 has a different LVDS CNV clock count maximum (8 vs 7), requiring
different driver configuration.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
No changes since v1.

 Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
index 106267aee195..79df2696ef24 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
@@ -33,6 +33,7 @@ properties:
       - adi,ad4085
       - adi,ad4086
       - adi,ad4087
+      - adi,ad4088
 
   reg:
     maxItems: 1
-- 
2.43.0
Re: [PATCH v2 5/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4088
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On 13/02/2026 15:46, Antoniu Miclaus wrote:
> Add device tree binding support for the AD4088 14-bit SAR ADC.
> Add adi,ad4088 to the compatible enum.
> 
> A fallback compatible string to adi,ad4080 is not appropriate as the
> AD4088 has a different LVDS CNV clock count maximum (8 vs 7), requiring
> different driver configuration.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> No changes since v1.

Not really acceptable. You ignored feedback and never responded to it.

Best regards,
Krzysztof
Re: [PATCH v2 5/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4088
Posted by Conor Dooley 1 month, 2 weeks ago
On Fri, Feb 13, 2026 at 04:46:26PM +0200, Antoniu Miclaus wrote:
> Add device tree binding support for the AD4088 14-bit SAR ADC.
> Add adi,ad4088 to the compatible enum.
> 
> A fallback compatible string to adi,ad4080 is not appropriate as the
> AD4088 has a different LVDS CNV clock count maximum (8 vs 7), requiring
> different driver configuration.

Same here, as your driver patch says:
|Add support for AD4088 14-bit SAR ADC. The AD4088 has the same
|resolution as AD4087 (14-bit) but differs in LVDS CNV clock count
|maximum (8 vs 1).

> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> No changes since v1.
> 
>  Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
> index 106267aee195..79df2696ef24 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
> @@ -33,6 +33,7 @@ properties:
>        - adi,ad4085
>        - adi,ad4086
>        - adi,ad4087
> +      - adi,ad4088
>  
>    reg:
>      maxItems: 1
> -- 
> 2.43.0
>