[PATCH v2 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085

Antoniu Miclaus posted 6 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH v2 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085
Posted by Antoniu Miclaus 1 month, 2 weeks ago
Add device tree binding support for the AD4085 16-bit SAR ADC.
Add adi,ad4085 to the compatible enum.

A fallback compatible string to adi,ad4080 is not appropriate as the
AD4085 has a different LVDS CNV clock count maximum (8 vs 7), requiring
different driver configuration.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
No changes since v1.

 Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
index eeabf99f9a12..106267aee195 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
@@ -30,6 +30,7 @@ properties:
       - adi,ad4082
       - adi,ad4083
       - adi,ad4084
+      - adi,ad4085
       - adi,ad4086
       - adi,ad4087
 
-- 
2.43.0
Re: [PATCH v2 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085
Posted by Krzysztof Kozlowski 1 month, 2 weeks ago
On Fri, Feb 13, 2026 at 04:46:24PM +0200, Antoniu Miclaus wrote:
> Add device tree binding support for the AD4085 16-bit SAR ADC.
> Add adi,ad4085 to the compatible enum.
> 
> A fallback compatible string to adi,ad4080 is not appropriate as the
> AD4085 has a different LVDS CNV clock count maximum (8 vs 7), requiring
> different driver configuration.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> No changes since v1.

So you just ignored entire feedback?

NAK

Best regards,
Krzysztof
Re: [PATCH v2 3/6] dt-bindings: iio: adc: adi,ad4080: add support for AD4085
Posted by Conor Dooley 1 month, 2 weeks ago
On Fri, Feb 13, 2026 at 04:46:24PM +0200, Antoniu Miclaus wrote:
> Add device tree binding support for the AD4085 16-bit SAR ADC.
> Add adi,ad4085 to the compatible enum.
> 
> A fallback compatible string to adi,ad4080 is not appropriate as the

Is citing 4080 a copy-paste mistake here? I assume you mean to reference
a different device in each of these three patches, each matching a
different accuracy?

> AD4085 has a different LVDS CNV clock count maximum (8 vs 7), requiring
> different driver configuration.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> No changes since v1.
> 
>  Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
> index eeabf99f9a12..106267aee195 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
> @@ -30,6 +30,7 @@ properties:
>        - adi,ad4082
>        - adi,ad4083
>        - adi,ad4084
> +      - adi,ad4085
>        - adi,ad4086
>        - adi,ad4087
>  
> -- 
> 2.43.0
>