[PATCH V3] arm64: dts: qcom: arduino-imola: fix faulty spidev node

Riccardo Mereu posted 1 patch 1 month, 2 weeks ago
arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
[PATCH V3] arm64: dts: qcom: arduino-imola: fix faulty spidev node
Posted by Riccardo Mereu 1 month, 2 weeks ago
From: Riccardo Mereu <r.mereu@arduino.cc>

CS pin added on pinctrl0 property is causing spidev to return -ENODEV
since that GPIO is already part of spi5 pinmuxing.

Fixes: 3f745bc0f11f ("arm64: dts: qcom: qrb2210: add dts for Arduino unoq")
Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
---

Changes since V2:
	- Changed spidev@0 nodename to mcu@0.
	- Changed properties order in same node to match DTS coding
	  style.

 arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
index 197ab6eb1666..5ab605cc56c8 100644
--- a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
+++ b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
@@ -325,21 +325,13 @@ &sdhc_1 {
 &spi5 {
 	status = "okay";
 
-	spidev@0 {
-		reg = <0>;
+	mcu@0 {
 		compatible = "arduino,unoq-mcu";
-		pinctrl-0 = <&spidev_cs>;
-		pinctrl-names = "default";
+		reg = <0>;
 	};
 };
 
 &tlmm {
-	spidev_cs: spidev-cs-state {
-		pins = "gpio17";
-		function = "gpio";
-		drive-strength = <16>;
-	};
-
 	jmisc_gpio18: jmisc-gpio18-state {
 		pins = "gpio18";
 		function = "gpio";
-- 
2.53.0
Re: [PATCH V3] arm64: dts: qcom: arduino-imola: fix faulty spidev node
Posted by Bjorn Andersson 2 weeks ago
On Fri, 13 Feb 2026 11:10:02 +0100, Riccardo Mereu wrote:
> CS pin added on pinctrl0 property is causing spidev to return -ENODEV
> since that GPIO is already part of spi5 pinmuxing.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: arduino-imola: fix faulty spidev node
      commit: 84d8976426072ea1a559ab1aaeff6bdc16248813

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
Re: [PATCH V3] arm64: dts: qcom: arduino-imola: fix faulty spidev node
Posted by Konrad Dybcio 1 month, 2 weeks ago
On 2/13/26 11:10 AM, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
> 
> CS pin added on pinctrl0 property is causing spidev to return -ENODEV
> since that GPIO is already part of spi5 pinmuxing.
> 
> Fixes: 3f745bc0f11f ("arm64: dts: qcom: qrb2210: add dts for Arduino unoq")
> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad