1. Patchew
  2. linux
  3. View series

[PATCH] platform/x86: intel-hid: Add Dell 14 Plus 2-in-1 to dmi_vgbs_allow_list

Peter Metz posted 1 patch 1 month, 2 weeks ago
There is a newer version of this series
drivers/platform/x86/intel/hid.c | 6 ++++++
1 file changed, 6 insertions(+)
[PATCH] platform/x86: intel-hid: Add Dell 14 Plus 2-in-1 to dmi_vgbs_allow_list
Posted by Peter Metz 1 month, 2 weeks ago 
The Dell 14 Plus 2-in-1 (model DB04250) requires the VGBS allow list
entry to correctly enable the tablet mode switch. Without this, the
chassis state is not reported, and the hinge rotation only emits
unknown scancodes.

Verified on Dell 14 Plus 2-in-1 DB04250.

Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221090
Signed-off-by: Peter Metz <peter.metz@unarin.com>
---
 drivers/platform/x86/intel/hid.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
index 560cc0631..5b475a096 100644
--- a/drivers/platform/x86/intel/hid.c
+++ b/drivers/platform/x86/intel/hid.c
@@ -189,6 +189,12 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Dell Pro Rugged 12 Tablet RA02260"),
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Dell 14 Plus 2-in-1 DB04250"),
+		},
+	},
 	{ }
 };
 
-- 
Cheers,
Peter Metz
Re: [PATCH] platform/x86: intel-hid: Add Dell 14 Plus 2-in-1 to dmi_vgbs_allow_list
Posted by Ilpo Järvinen 1 month, 1 week ago 
On Thu, 12 Feb 2026 23:46:27 -0500, Peter Metz wrote:

> The Dell 14 Plus 2-in-1 (model DB04250) requires the VGBS allow list
> entry to correctly enable the tablet mode switch. Without this, the
> chassis state is not reported, and the hinge rotation only emits
> unknown scancodes.
> 
> Verified on Dell 14 Plus 2-in-1 DB04250.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: intel-hid: Add Dell 14 Plus 2-in-1 to dmi_vgbs_allow_list
      commit: 6b3fa0615cd8432148581de62a52f83847af3d70
[2/2] platform/x86: intel-hid: Add Dell 16 Plus 2-in-1 to dmi_vgbs_allow_list
      commit: 857f5036f8fd729e097efbe3ba421b75e27346cb

--
 i.
Re: [PATCH] platform/x86: intel-hid: Add Dell 14 Plus 2-in-1 to dmi_vgbs_allow_list
Posted by Peter Metz 1 month ago 
My pleasure Ilpo!
Thank you for the review and no rush at all of course.

Cheers,
Peter

On 2/23/26 11:34 AM, Ilpo Järvinen wrote:
> On Thu, 12 Feb 2026 23:46:27 -0500, Peter Metz wrote:
>
>> The Dell 14 Plus 2-in-1 (model DB04250) requires the VGBS allow list
>> entry to correctly enable the tablet mode switch. Without this, the
>> chassis state is not reported, and the hinge rotation only emits
>> unknown scancodes.
>>
>> Verified on Dell 14 Plus 2-in-1 DB04250.
>>
>> [...]
>
> Thank you for your contribution, it has been applied to my local
> review-ilpo-fixes branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
> local branch there, which might take a while.
>
> The list of commits applied:
> [1/1] platform/x86: intel-hid: Add Dell 14 Plus 2-in-1 to dmi_vgbs_allow_list
>        commit: 6b3fa0615cd8432148581de62a52f83847af3d70
> [2/2] platform/x86: intel-hid: Add Dell 16 Plus 2-in-1 to dmi_vgbs_allow_list
>        commit: 857f5036f8fd729e097efbe3ba421b75e27346cb
>
> --
>   i.
>
Re: [PATCH] platform/x86: intel-hid: Add Dell 14 Plus 2-in-1 to dmi_vgbs_allow_list
Posted by Hans de Goede 1 month, 2 weeks ago 
Hi,

On 13-Feb-26 05:46, Peter Metz wrote:
> The Dell 14 Plus 2-in-1 (model DB04250) requires the VGBS allow list
> entry to correctly enable the tablet mode switch. Without this, the
> chassis state is not reported, and the hinge rotation only emits
> unknown scancodes.
> 
> Verified on Dell 14 Plus 2-in-1 DB04250.
> 
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221090
> Signed-off-by: Peter Metz <peter.metz@unarin.com>

p.s.

If you feel up to it, there is a similar bug-report of a related
Dell model here:

https://lore.kernel.org/platform-driver-x86/CAP3yi-BWm0LqkhfzTrGy5n-KQ=3+T8eRMoR+Z+7Ke2VJB43kTA@mail.gmail.com/

it would be great if you can write a follow-up patch fixing
that one too.

Regards,

Hans



> ---
>  drivers/platform/x86/intel/hid.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
> index 560cc0631..5b475a096 100644
> --- a/drivers/platform/x86/intel/hid.c
> +++ b/drivers/platform/x86/intel/hid.c
> @@ -189,6 +189,12 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Dell Pro Rugged 12 Tablet RA02260"),
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Dell 14 Plus 2-in-1 DB04250"),
> +		},
> +	},
>  	{ }
>  };
>
[PATCH 2/2] platform/x86: intel-hid: Add Dell 16 Plus 2-in-1 to dmi_vgbs_allow_list
Posted by Peter Metz 1 month, 2 weeks ago 
The Dell 16 Plus 2-in-1 (model DB06250) requires the VGBS allow list
entry to correctly enable the tablet mode switch. Without this, the
chassis state is not reported, and the hinge rotation only emits
unknown scancodes.

Link: https://lore.kernel.org/platform-driver-x86/CAP3yi-BWm0LqkhfzTrGy5n-KQ=3+T8eRMoR+Z+7Ke2VJB43kTA@mail.gmail.com/
Signed-off-by: Peter Metz <peter.metz@unarin.com>
---
Hi Hans,

Thanks for the review! I'd be happy to help out with more fixes.
Here is the follow-up patch for the Dell 16 Plus (DB06250)
to address that report.

Cheers,
Peter

 drivers/platform/x86/intel/hid.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
index 60ce32f591ff..a8ae2dba7ffd 100644
--- a/drivers/platform/x86/intel/hid.c
+++ b/drivers/platform/x86/intel/hid.c
@@ -195,6 +195,12 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Dell 14 Plus 2-in-1 DB04250"),
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Dell 16 Plus 2-in-1 DB06250"),
+		},
+	},
 	{ }
 };
 
-- 
Cheers,
Peter Metz
Re: [PATCH 2/2] platform/x86: intel-hid: Add Dell 16 Plus 2-in-1 to dmi_vgbs_allow_list
Posted by Hans de Goede 1 month, 2 weeks ago 
Hi,

On 13-Feb-26 23:58, Peter Metz wrote:
> The Dell 16 Plus 2-in-1 (model DB06250) requires the VGBS allow list
> entry to correctly enable the tablet mode switch. Without this, the
> chassis state is not reported, and the hinge rotation only emits
> unknown scancodes.
> 
> Link: https://lore.kernel.org/platform-driver-x86/CAP3yi-BWm0LqkhfzTrGy5n-KQ=3+T8eRMoR+Z+7Ke2VJB43kTA@mail.gmail.com/
> Signed-off-by: Peter Metz <peter.metz@unarin.com>
> ---
> Hi Hans,
> 
> Thanks for the review! I'd be happy to help out with more fixes.
> Here is the follow-up patch for the Dell 16 Plus (DB06250)
> to address that report.

Thank you!

patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

Regards,

Hans




>  drivers/platform/x86/intel/hid.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
> index 60ce32f591ff..a8ae2dba7ffd 100644
> --- a/drivers/platform/x86/intel/hid.c
> +++ b/drivers/platform/x86/intel/hid.c
> @@ -195,6 +195,12 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Dell 14 Plus 2-in-1 DB04250"),
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Dell 16 Plus 2-in-1 DB06250"),
> +		},
> +	},
>  	{ }
>  };
>
Re: [PATCH] platform/x86: intel-hid: Add Dell 14 Plus 2-in-1 to dmi_vgbs_allow_list
Posted by Hans de Goede 1 month, 2 weeks ago 
Hi,

On 13-Feb-26 05:46, Peter Metz wrote:
> The Dell 14 Plus 2-in-1 (model DB04250) requires the VGBS allow list
> entry to correctly enable the tablet mode switch. Without this, the
> chassis state is not reported, and the hinge rotation only emits
> unknown scancodes.
> 
> Verified on Dell 14 Plus 2-in-1 DB04250.
> 
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221090
> Signed-off-by: Peter Metz <peter.metz@unarin.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>

Regards,

Hans




> ---
>  drivers/platform/x86/intel/hid.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel/hid.c b/drivers/platform/x86/intel/hid.c
> index 560cc0631..5b475a096 100644
> --- a/drivers/platform/x86/intel/hid.c
> +++ b/drivers/platform/x86/intel/hid.c
> @@ -189,6 +189,12 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Dell Pro Rugged 12 Tablet RA02260"),
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Dell 14 Plus 2-in-1 DB04250"),
> +		},
> +	},
>  	{ }
>  };
>

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.