[PATCH v2 04/12] powercap: intel_rapl: Simplify rapl_compute_time_window_atom()

Kuppuswamy Sathyanarayanan posted 12 patches 1 month, 2 weeks ago
[PATCH v2 04/12] powercap: intel_rapl: Simplify rapl_compute_time_window_atom()
Posted by Kuppuswamy Sathyanarayanan 1 month, 2 weeks ago
Restructure to use early return for to_raw case, eliminating
redundant assignments and clarifying conversion paths.

No functional changes.

Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/powercap/intel_rapl_common.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
index d37150bab1e2..74a74af8f0ec 100644
--- a/drivers/powercap/intel_rapl_common.c
+++ b/drivers/powercap/intel_rapl_common.c
@@ -1145,16 +1145,14 @@ static u64 rapl_compute_time_window_core(struct rapl_domain *rd, u64 value,
 static u64 rapl_compute_time_window_atom(struct rapl_domain *rd, u64 value,
 					 bool to_raw)
 {
+	if (to_raw)
+		return div64_u64(value, rd->time_unit);
+
 	/*
 	 * Atom time unit encoding is straight forward val * time_unit,
 	 * where time_unit is default to 1 sec. Never 0.
 	 */
-	if (!to_raw)
-		return (value) ? value * rd->time_unit : rd->time_unit;
-
-	value = div64_u64(value, rd->time_unit);
-
-	return value;
+	return (value) ? value * rd->time_unit : rd->time_unit;
 }
 
 static int rapl_check_unit_tpmi(struct rapl_domain *rd)
-- 
2.43.0