[v2] arm64: dts: qcom: arduino-imola: fix faulty spidev node

[PATCH V2] arm64: dts: qcom: arduino-imola: fix faulty spidev node

Posted by Riccardo Mereu 1 month, 2 weeks ago

From: Riccardo Mereu <r.mereu@arduino.cc>

CS pin added on pinctrl0 property is causing spidev to return -ENODEV
since that GPIO is already part of spi5 pinmuxing.

Fixes: 3f745bc0f11f ("arm64: dts: qcom: qrb2210: add dts for Arduino unoq")
Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
---
 arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
index 197ab6eb1666..796c1f7ff17c 100644
--- a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
+++ b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
@@ -328,18 +328,10 @@ &spi5 {
 	spidev@0 {
 		reg = <0>;
 		compatible = "arduino,unoq-mcu";
-		pinctrl-0 = <&spidev_cs>;
-		pinctrl-names = "default";
 	};
 };
 
 &tlmm {
-	spidev_cs: spidev-cs-state {
-		pins = "gpio17";
-		function = "gpio";
-		drive-strength = <16>;
-	};
-
 	jmisc_gpio18: jmisc-gpio18-state {
 		pins = "gpio18";
 		function = "gpio";
-- 
2.53.0

Re: [PATCH V2] arm64: dts: qcom: arduino-imola: fix faulty spidev node

Posted by Conor Dooley 1 month, 2 weeks ago

On Thu, Feb 12, 2026 at 04:23:29PM +0100, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
> 
> CS pin added on pinctrl0 property is causing spidev to return -ENODEV
> since that GPIO is already part of spi5 pinmuxing.
> 
> Fixes: 3f745bc0f11f ("arm64: dts: qcom: qrb2210: add dts for Arduino unoq")
> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> ---
>  arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> index 197ab6eb1666..796c1f7ff17c 100644
> --- a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts
> @@ -328,18 +328,10 @@ &spi5 {
>  	spidev@0 {

Of you're modifying this node, you should fix the nodename too. "spidev"
isn't a type of device. It should probably either be "mcu@" or whatever
the mcu is used for.

>  		reg = <0>;
>  		compatible = "arduino,unoq-mcu";
> -		pinctrl-0 = <&spidev_cs>;
> -		pinctrl-names = "default";
>  	};
>  };
>  
>  &tlmm {
> -	spidev_cs: spidev-cs-state {
> -		pins = "gpio17";
> -		function = "gpio";
> -		drive-strength = <16>;
> -	};
> -
>  	jmisc_gpio18: jmisc-gpio18-state {
>  		pins = "gpio18";
>  		function = "gpio";
> -- 
> 2.53.0
>

Re: [PATCH V2] arm64: dts: qcom: arduino-imola: fix faulty spidev node

Posted by Konrad Dybcio 1 month, 2 weeks ago

On 2/12/26 4:23 PM, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu@arduino.cc>
> 
> CS pin added on pinctrl0 property is causing spidev to return -ENODEV
> since that GPIO is already part of spi5 pinmuxing.
> 
> Fixes: 3f745bc0f11f ("arm64: dts: qcom: qrb2210: add dts for Arduino unoq")
> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> ---

note: usually one would include a short changelog under the --- line,
but here I still remember it was "also remove pinctrl-names override"

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad