[PATCH] KVM: x86/pmu: annotate struct kvm_x86_pmu_event_filter with __counted_by()

Carlos López posted 1 patch 1 month, 2 weeks ago
arch/x86/include/asm/kvm_host.h | 2 +-
arch/x86/kvm/pmu.c              | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
[PATCH] KVM: x86/pmu: annotate struct kvm_x86_pmu_event_filter with __counted_by()
Posted by Carlos López 1 month, 2 weeks ago
struct kvm_x86_pmu_event_filter has a flexible array member, so annotate
it with the field that describes the amount of entries in such array.
Opportunistically replace the open-coded array size calculation with
flex_array_size() when copying the array portion of the struct from
userspace.

Signed-off-by: Carlos López <clopez@suse.de>
---
 arch/x86/include/asm/kvm_host.h | 2 +-
 arch/x86/kvm/pmu.c              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index ff07c45e3c73..d9159b969bd9 100644
--- a/arch/x86/include/asm/kvm_host.h
+++ b/arch/x86/include/asm/kvm_host.h
@@ -1261,7 +1261,7 @@ struct kvm_x86_pmu_event_filter {
 	__u32 nr_excludes;
 	__u64 *includes;
 	__u64 *excludes;
-	__u64 events[];
+	__u64 events[] __counted_by(nevents);
 };
 
 enum kvm_apicv_inhibit {
diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
index bd6b785cf261..e218352e3423 100644
--- a/arch/x86/kvm/pmu.c
+++ b/arch/x86/kvm/pmu.c
@@ -1256,7 +1256,7 @@ int kvm_vm_ioctl_set_pmu_event_filter(struct kvm *kvm, void __user *argp)
 
 	r = -EFAULT;
 	if (copy_from_user(filter->events, user_filter->events,
-			   sizeof(filter->events[0]) * filter->nevents))
+			   flex_array_size(filter, events, filter->nevents)))
 		goto cleanup;
 
 	r = prepare_filter_lists(filter);

base-commit: e944fe2c09f405a2e2d147145c9b470084bc4c9a
-- 
2.51.0

Re: [PATCH] KVM: x86/pmu: annotate struct kvm_x86_pmu_event_filter with __counted_by()
Posted by Sean Christopherson 4 weeks ago
On Thu, 12 Feb 2026 15:05:56 +0100, Carlos López wrote:
> struct kvm_x86_pmu_event_filter has a flexible array member, so annotate
> it with the field that describes the amount of entries in such array.
> Opportunistically replace the open-coded array size calculation with
> flex_array_size() when copying the array portion of the struct from
> userspace.
> 
> 
> [...]

Applied to kvm-x86 misc, thanks!

[1/1] KVM: x86/pmu: annotate struct kvm_x86_pmu_event_filter with __counted_by()
      https://github.com/kvm-x86/linux/commit/c522ac04ba9d

--
https://github.com/kvm-x86/linux/tree/next