[PATCH v2 1/4] clk: at91: sam9x7: Remove gmac peripheral and generic clock entries with ID 67

Mihai Sain posted 4 patches 1 month, 2 weeks ago
There is a newer version of this series
[PATCH v2 1/4] clk: at91: sam9x7: Remove gmac peripheral and generic clock entries with ID 67
Posted by Mihai Sain 1 month, 2 weeks ago
According with datasheet table 12.1 the instance ID 67 is reserved.
This change drops the gmactsu_clk and gmac_gclk entries from
the SAM9X7 clock description tables.

Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
---
 drivers/clk/at91/sam9x7.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/clk/at91/sam9x7.c b/drivers/clk/at91/sam9x7.c
index 89868a0aeaba..d9603f1124d0 100644
--- a/drivers/clk/at91/sam9x7.c
+++ b/drivers/clk/at91/sam9x7.c
@@ -420,7 +420,6 @@ static const struct {
 	{ .n = "lvdsc_clk",	.id = 56, },
 	{ .n = "pit64b1_clk",	.id = 58, },
 	{ .n = "puf_clk",	.id = 59, },
-	{ .n = "gmactsu_clk",	.id = 67, },
 };
 
 /*
@@ -702,15 +701,6 @@ static const struct {
 		.pp_count = 1,
 		.pp_chg_id = INT_MIN,
 	},
-
-	{
-		.n = "gmac_gclk",
-		.id = 67,
-		.pp = { "audiopll_divpmcck", "plla_div2pmcck", },
-		.pp_mux_table = { 6, 8, },
-		.pp_count = 2,
-		.pp_chg_id = INT_MIN,
-	},
 };
 
 static void __init sam9x7_pmc_setup(struct device_node *np)
-- 
2.53.0
Re: [PATCH v2 1/4] clk: at91: sam9x7: Remove gmac peripheral and generic clock entries with ID 67
Posted by Claudiu Beznea 1 month ago
Hi, Mihai,

On 2/12/26 12:01, Mihai Sain wrote:
> According with datasheet table 12.1 the instance ID 67 is reserved.

Could you please mention the datasheet revision ID?

> This change drops the gmactsu_clk and gmac_gclk entries from
> the SAM9X7 clock description tables.
> 
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
>   drivers/clk/at91/sam9x7.c | 10 ----------
>   1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/clk/at91/sam9x7.c b/drivers/clk/at91/sam9x7.c
> index 89868a0aeaba..d9603f1124d0 100644
> --- a/drivers/clk/at91/sam9x7.c
> +++ b/drivers/clk/at91/sam9x7.c
> @@ -420,7 +420,6 @@ static const struct {
>   	{ .n = "lvdsc_clk",	.id = 56, },
>   	{ .n = "pit64b1_clk",	.id = 58, },
>   	{ .n = "puf_clk",	.id = 59, },
> -	{ .n = "gmactsu_clk",	.id = 67, },

Could you please keep this in a separate patch?

>   };
>   
>   /*
> @@ -702,15 +701,6 @@ static const struct {
>   		.pp_count = 1,
>   		.pp_chg_id = INT_MIN,
>   	},
> -
> -	{
> -		.n = "gmac_gclk",
> -		.id = 67,
> -		.pp = { "audiopll_divpmcck", "plla_div2pmcck", },
> -		.pp_mux_table = { 6, 8, },
> -		.pp_count = 2,
> -		.pp_chg_id = INT_MIN,
> -	},

And squash this changes with patch 3/4 "clk: at91: sam9x7: Add gmac generic 
clock entry with ID 24" and also provide a fixes tag for it?

Thank you,
Claudiu