[v1] clk: imx: imx8-acm: fix flags for acm clocks

[PATCH RESEND] clk: imx: imx8-acm: fix flags for acm clocks

Posted by Shengjiu Wang 1 month, 2 weeks ago

From: Stefan Eichenberger <stefan.eichenberger@toradex.com>

Currently, the flags for the ACM clocks are set to 0. This configuration
causes the fsl-sai audio driver to fail when attempting to set the
sysclk, returning an EINVAL error. The following error messages
highlight the issue:
fsl-sai 59090000.sai: ASoC: error at snd_soc_dai_set_sysclk on 59090000.sai: -22
imx-hdmi sound-hdmi: failed to set cpu sysclk: -22

By setting the flag CLK_SET_RATE_NO_REPARENT, we signal that the ACM
driver does not support reparenting and instead relies on the clock tree
as defined in the device tree. This change resolves the issue with the
fsl-sai audio driver.

CC: stable@vger.kernel.org
Fixes: d3a0946d7ac9 ("clk: imx: imx8: add audio clock mux driver")
Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---

Reason for RESEND:
- I think this patch still need, link of previous discussion
  https://lore.kernel.org/all/20250113094654.12998-1-eichest@gmail.com/

 drivers/clk/imx/clk-imx8-acm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-imx8-acm.c b/drivers/clk/imx/clk-imx8-acm.c
index 790f7e44b11e..07dca6f31cf8 100644
--- a/drivers/clk/imx/clk-imx8-acm.c
+++ b/drivers/clk/imx/clk-imx8-acm.c
@@ -371,7 +371,8 @@ static int imx8_acm_clk_probe(struct platform_device *pdev)
 	for (i = 0; i < priv->soc_data->num_sels; i++) {
 		hws[sels[i].clkid] = devm_clk_hw_register_mux_parent_data_table(dev,
 										sels[i].name, sels[i].parents,
-										sels[i].num_parents, 0,
+										sels[i].num_parents,
+										CLK_SET_RATE_NO_REPARENT,
 										base + sels[i].reg,
 										sels[i].shift, sels[i].width,
 										0, NULL, NULL);
-- 
2.34.1

Re: [PATCH RESEND] clk: imx: imx8-acm: fix flags for acm clocks

Posted by Abel Vesa 2 weeks, 1 day ago

On Thu, 12 Feb 2026 16:57:50 +0800, Shengjiu Wang wrote:
> Currently, the flags for the ACM clocks are set to 0. This configuration
> causes the fsl-sai audio driver to fail when attempting to set the
> sysclk, returning an EINVAL error. The following error messages
> highlight the issue:
> fsl-sai 59090000.sai: ASoC: error at snd_soc_dai_set_sysclk on 59090000.sai: -22
> imx-hdmi sound-hdmi: failed to set cpu sysclk: -22
> 
> [...]

Applied, thanks!

[1/1] clk: imx: imx8-acm: fix flags for acm clocks
      commit: 01898eb94e4e7b70b6e89f874494cc18f4954e1b

Best regards,
-- 
Abel Vesa <abel.vesa@oss.qualcomm.com>

Re: [PATCH RESEND] clk: imx: imx8-acm: fix flags for acm clocks

Posted by Peng Fan 1 month ago

On Thu, Feb 12, 2026 at 04:57:50PM +0800, Shengjiu Wang wrote:
>From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
>
>Currently, the flags for the ACM clocks are set to 0. This configuration
>causes the fsl-sai audio driver to fail when attempting to set the
>sysclk, returning an EINVAL error. The following error messages
>highlight the issue:
>fsl-sai 59090000.sai: ASoC: error at snd_soc_dai_set_sysclk on 59090000.sai: -22
>imx-hdmi sound-hdmi: failed to set cpu sysclk: -22
>
>By setting the flag CLK_SET_RATE_NO_REPARENT, we signal that the ACM
>driver does not support reparenting and instead relies on the clock tree
>as defined in the device tree. This change resolves the issue with the
>fsl-sai audio driver.
>
>CC: stable@vger.kernel.org
>Fixes: d3a0946d7ac9 ("clk: imx: imx8: add audio clock mux driver")
>Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
>Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>