[v1] selftests/bpf: Fixes for userspace ASAN

[PATCH bpf-next v1 07/14] veristat: Fix a memory leak for preset ENUMERATOR

Posted by Ihor Solodrai 1 month, 2 weeks ago

ASAN detected a memory leak in veristat. The cleanup code handling
ENUMERATOR value missed freeing strdup-ed svalue. Fix it.

Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
---
 tools/testing/selftests/bpf/veristat.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/bpf/veristat.c b/tools/testing/selftests/bpf/veristat.c
index 1be1e353d40a..75f85e0362f5 100644
--- a/tools/testing/selftests/bpf/veristat.c
+++ b/tools/testing/selftests/bpf/veristat.c
@@ -3378,6 +3378,8 @@ int main(int argc, char **argv)
 			}
 		}
 		free(env.presets[i].atoms);
+		if (env.presets[i].value.type == ENUMERATOR)
+			free(env.presets[i].value.svalue);
 	}
 	free(env.presets);
 	return -err;
-- 
2.53.0

Re: [PATCH bpf-next v1 07/14] veristat: Fix a memory leak for preset ENUMERATOR

Posted by Mykyta Yatsenko 1 month, 2 weeks ago

On 2/12/26 01:13, Ihor Solodrai wrote:
> ASAN detected a memory leak in veristat. The cleanup code handling
> ENUMERATOR value missed freeing strdup-ed svalue. Fix it.
>
> Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
> ---
>   tools/testing/selftests/bpf/veristat.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/veristat.c b/tools/testing/selftests/bpf/veristat.c
> index 1be1e353d40a..75f85e0362f5 100644
> --- a/tools/testing/selftests/bpf/veristat.c
> +++ b/tools/testing/selftests/bpf/veristat.c
> @@ -3378,6 +3378,8 @@ int main(int argc, char **argv)
>   			}
>   		}
>   		free(env.presets[i].atoms);
> +		if (env.presets[i].value.type == ENUMERATOR)
> +			free(env.presets[i].value.svalue);
>   	}
>   	free(env.presets);
>   	return -err;
Thanks for fixing!
Acked-by: Mykyta Yatsenko <yatsenko@meta.com>