iio: adc: pac1934: Return -ENOMEM on memory allocation failure

[PATCH] iio: adc: pac1934: Return -ENOMEM on memory allocation failure

Posted by Antoniu Miclaus 1 month, 2 weeks ago

devm_kzalloc() returns NULL on allocation failure. The appropriate error
code for this condition is -ENOMEM, not -EINVAL.

Fixes: 0fb528c8255b ("iio: adc: adding support for PAC193x")
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/adc/pac1934.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/pac1934.c b/drivers/iio/adc/pac1934.c
index ec96bb0f2ed6..b791ce23f3fd 100644
--- a/drivers/iio/adc/pac1934.c
+++ b/drivers/iio/adc/pac1934.c
@@ -1351,7 +1351,7 @@ static int pac1934_prep_iio_channels(struct pac1934_chip_info *info, struct iio_
 
 	dyn_ch_struct = devm_kzalloc(dev, channel_size, GFP_KERNEL);
 	if (!dyn_ch_struct)
-		return -EINVAL;
+		return -ENOMEM;
 
 	tmp_data = dyn_ch_struct;
 
-- 
2.43.0

Re: [PATCH] iio: adc: pac1934: Return -ENOMEM on memory allocation failure

Posted by Jonathan Cameron 1 month, 2 weeks ago

On Wed, 11 Feb 2026 19:10:05 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> devm_kzalloc() returns NULL on allocation failure. The appropriate error
> code for this condition is -ENOMEM, not -EINVAL.
> 
> Fixes: 0fb528c8255b ("iio: adc: adding support for PAC193x")

Given it's a small alloc and in practice those don't fail if you machine
is likely to boot and at worst you get a slightly misleading error code,
I don't think backports are appropriate, so I've applied this
dropping the fixes tag.


> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
>  drivers/iio/adc/pac1934.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/pac1934.c b/drivers/iio/adc/pac1934.c
> index ec96bb0f2ed6..b791ce23f3fd 100644
> --- a/drivers/iio/adc/pac1934.c
> +++ b/drivers/iio/adc/pac1934.c
> @@ -1351,7 +1351,7 @@ static int pac1934_prep_iio_channels(struct pac1934_chip_info *info, struct iio_
>  
>  	dyn_ch_struct = devm_kzalloc(dev, channel_size, GFP_KERNEL);
>  	if (!dyn_ch_struct)
> -		return -EINVAL;
> +		return -ENOMEM;
>  
>  	tmp_data = dyn_ch_struct;
>

Re: [PATCH] iio: adc: pac1934: Return -ENOMEM on memory allocation failure

Posted by Andy Shevchenko 1 month, 2 weeks ago

On Wed, Feb 11, 2026 at 7:10 PM Antoniu Miclaus
<antoniu.miclaus@analog.com> wrote:
>
> devm_kzalloc() returns NULL on allocation failure. The appropriate error
> code for this condition is -ENOMEM, not -EINVAL.

Right, and the memory allocator dumps enough info if it happens.
Reviewed-by: Andy Shevchenko <andy@kernel.org>

-- 
With Best Regards,
Andy Shevchenko