hi,
we can currently optimize uprobes on top of nop5 instructions,
so application can define USDT_NOP to nop5 and use USDT macro
to define optimized usdt probes.
This works fine on new kernels, but could have performance penalty
on older kernels, that do not have the support to optimize and to
emulate nop5 instruction.
This patchset adds support to workaround the performance penalty
on older kernels that do not support uprobe optimization, please
see detailed description in patch 2.
v1: https://lore.kernel.org/bpf/20251117083551.517393-1-jolsa@kernel.org/
v2: https://lore.kernel.org/bpf/20260210133649.524292-1-jolsa@kernel.org/
v3 changes:
- fix __x86_64 define and other typos [CI]
- add missing '?' to usdt trigger program [CI]
v2 changes:
- after more investigation we realized there are some versions of
bpftrace and stap that does not work with solution suggested in
version 1, so we decided to switch to following solution:
- change USDT macro [1] emits nop,nop5 instructions combo by
default
- libbpf detects nop,nop5 instructions combo for USDT probe,
if there is and if uprobe syscall is detected libbpf installs
usdt probe on top of nop5 instruction to get it optimized
- added usdt trigger benchmarks [Andrii]
- several small fixes on uprobe syscall detection, tests and other places [Andrii]
- true usdt.h source [1] updated [Andrii]
- compile usdt_* objects unconditionally [Andrii]
thanks,
jirka
[1] https://github.com/libbpf/usdt
---
Jiri Olsa (5):
selftests/bpf: Emit nop,no5 instructions combo for x86_64 arch
libbpf: Add uprobe syscall feature detection
libbpf: Add support to detect nop,nop5 instructions combo for usdt probe
selftests/bpf: Add test for checking correct nop of optimized usdt
selftests/bpf: Add usdt trigger bench
tools/lib/bpf/features.c | 24 ++++++++++++++++++++++++
tools/lib/bpf/libbpf_internal.h | 2 ++
tools/lib/bpf/usdt.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++----
tools/testing/selftests/bpf/.gitignore | 2 ++
tools/testing/selftests/bpf/Makefile | 5 ++++-
tools/testing/selftests/bpf/bench.c | 4 ++++
tools/testing/selftests/bpf/benchs/bench_trigger.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
tools/testing/selftests/bpf/benchs/run_bench_uprobes.sh | 2 +-
tools/testing/selftests/bpf/prog_tests/usdt.c | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
tools/testing/selftests/bpf/progs/test_usdt.c | 9 +++++++++
tools/testing/selftests/bpf/progs/trigger_bench.c | 10 +++++++++-
tools/testing/selftests/bpf/usdt.h | 2 ++
tools/testing/selftests/bpf/usdt_1.c | 18 ++++++++++++++++++
tools/testing/selftests/bpf/usdt_2.c | 16 ++++++++++++++++
14 files changed, 287 insertions(+), 7 deletions(-)
create mode 100644 tools/testing/selftests/bpf/usdt_1.c
create mode 100644 tools/testing/selftests/bpf/usdt_2.c