[PATCH] sched/rt: Remove empty sched_rt_do_global() helper

Zhan Xusheng posted 1 patch 1 month, 2 weeks ago
kernel/sched/rt.c | 5 -----
1 file changed, 5 deletions(-)
[PATCH] sched/rt: Remove empty sched_rt_do_global() helper
Posted by Zhan Xusheng 1 month, 2 weeks ago
sched_rt_do_global() is an empty helper that has no effect on
RT bandwidth sysctl handling.

Historically, sched_rt_do_global() was responsible for managing
RT throttling parameters before the introduction of the fair
server. Since commit 5f6bd380c7bd ("sched/rt: Remove default
bandwidth control"), the function became obsolete, but the empty
helper and its call site were retained.

Remove the unused function and its call site to simplify the
sysctl update path.

No functional change intended.

Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com>
Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
---
 kernel/sched/rt.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index a7680477fa6f..f49b75d36428 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -2862,10 +2862,6 @@ static int sched_rt_global_validate(void)
 	return 0;
 }
 
-static void sched_rt_do_global(void)
-{
-}
-
 static int sched_rt_handler(const struct ctl_table *table, int write, void *buffer,
 		size_t *lenp, loff_t *ppos)
 {
@@ -2893,7 +2889,6 @@ static int sched_rt_handler(const struct ctl_table *table, int write, void *buff
 		if (ret)
 			goto undo;
 
-		sched_rt_do_global();
 		sched_dl_do_global();
 	}
 	if (0) {
-- 
2.43.0
Re: [PATCH] sched/rt: Remove empty sched_rt_do_global() helper
Posted by K Prateek Nayak 1 month, 2 weeks ago
(+Steve)

Hello Zhan,

On 2/11/2026 12:41 PM, Zhan Xusheng wrote:
> sched_rt_do_global() is an empty helper that has no effect on
> RT bandwidth sysctl handling.
> 
> Historically, sched_rt_do_global() was responsible for managing
> RT throttling parameters before the introduction of the fair
> server. Since commit 5f6bd380c7bd ("sched/rt: Remove default
> bandwidth control"), the function became obsolete, but the empty
> helper and its call site were retained.
> 
> Remove the unused function and its call site to simplify the
> sysctl update path.
> 
> No functional change intended.
> 
> Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com>
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>

I believe there is another competing cleanup by Michal at
https://lore.kernel.org/lkml/20260119-sched-rert_groups-v1-0-80c1e5269910@suse.com/
which is doing a little bit more.

I'll leave it to Peter / Steve to pick which one they prefer.

-- 
Thanks and Regards,
Prateek
Re: [PATCH] sched/rt: Remove empty sched_rt_do_global() helper
Posted by Steven Rostedt 1 month, 2 weeks ago
On Wed, 11 Feb 2026 13:55:12 +0530
K Prateek Nayak <kprateek.nayak@amd.com> wrote:

> I'll leave it to Peter / Steve to pick which one they prefer.

It should go through Peter.

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve