[v1] staging: rtl8723bs: split multiple assignment in osdep_service.c

[PATCH] staging: rtl8723bs: split multiple assignment in osdep_service.c

Posted by Juyeong Jun 1 month, 2 weeks ago

From: grizzo <grizzo@ubuntu22.04.myguest.virtualbox.org>

Avoid multiple assignments in a single statement.
No functional change.
---
 drivers/staging/rtl8723bs/os_dep/osdep_service.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index a00f9f0c85c5..19b378b49809 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -226,7 +226,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size)
 	cbuf = rtw_malloc(struct_size(cbuf, bufs, size));
 
 	if (cbuf) {
-		cbuf->write = cbuf->read = 0;
+		cbuf->write = 0;
+		cbuf->read = 0;
 		cbuf->size = size;
 	}
 
-- 
2.34.1

Re: [PATCH] staging: rtl8723bs: split multiple assignment in osdep_service.c

Posted by Greg Kroah-Hartman 1 month, 2 weeks ago

On Wed, Feb 11, 2026 at 04:04:12PM +0900, Juyeong Jun wrote:
> From: grizzo <grizzo@ubuntu22.04.myguest.virtualbox.org>

Something went wrong with your git setup :(

[PATCH] staging: rtl8723bs: split multiple assignment in osdep_service.c

Posted by Juyeong Jun 1 month, 2 weeks ago

v2:
- Fix incorrect Author email in commit

Sorry for the mistake. This is my first time, and I sent a new email instead of a reply. Resending as a reply. My apologies

Avoid multiple assignments in a single statement.
No functional change.
---
 drivers/staging/rtl8723bs/os_dep/osdep_service.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index a00f9f0c85c5..19b378b49809 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -226,7 +226,8 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size)
 	cbuf = rtw_malloc(struct_size(cbuf, bufs, size));
 
 	if (cbuf) {
-		cbuf->write = cbuf->read = 0;
+		cbuf->write = 0;
+		cbuf->read = 0;
 		cbuf->size = size;
 	}
 
-- 
2.34.1

Re: [PATCH] staging: rtl8723bs: split multiple assignment in osdep_service.c

Posted by Dan Carpenter 1 month, 2 weeks ago

On Wed, Feb 11, 2026 at 06:46:34PM +0900, Juyeong Jun wrote:
> v2:
> - Fix incorrect Author email in commit
> 
> Sorry for the mistake. This is my first time, and I sent a new email instead of a reply. Resending as a reply. My apologies
> 
> Avoid multiple assignments in a single statement.
> No functional change.
> ---

This isn't the right format.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter