[v1] Avoid filesystem references to writeback internals

[PATCH 0/4] Avoid filesystem references to writeback internals

Posted by Kundan Kumar 1 month, 2 weeks ago

The series introduces writeback helper APIs and converts f2fs, gfs2
and nfs to stop accessing writeback internals directly.

As suggested by Christoph [1], filesystem code that directly accesses
writeback internals is split out:
[1] https://lore.kernel.org/all/20251015072912.GA11294@lst.de/

No functional changes intended

Kundan Kumar (4):
  writeback: prep helpers for dirty-limit and writeback accounting
  f2fs: stop using writeback internals for dirty_exceeded checks
  gfs2: stop using writeback internals for dirty_exceeded check
  nfs: stop using writeback internals for WB_WRITEBACK accounting

 fs/f2fs/node.c              |  4 ++--
 fs/f2fs/segment.h           |  2 +-
 fs/gfs2/super.c             |  2 +-
 fs/nfs/internal.h           |  2 +-
 fs/nfs/write.c              |  4 ++--
 include/linux/backing-dev.h | 11 +++++++++++
 6 files changed, 18 insertions(+), 7 deletions(-)


base-commit: 05f7e89ab9731565d8a62e3b5d1ec206485eeb0b
-- 
2.25.1

Re: [PATCH 0/4] Avoid filesystem references to writeback internals

Posted by Jeff Layton 1 month, 2 weeks ago

On Wed, 2026-02-11 at 12:30 +0530, Kundan Kumar wrote:
> The series introduces writeback helper APIs and converts f2fs, gfs2
> and nfs to stop accessing writeback internals directly.
> 
> As suggested by Christoph [1], filesystem code that directly accesses
> writeback internals is split out:
> [1] https://lore.kernel.org/all/20251015072912.GA11294@lst.de/
> 
> No functional changes intended
> 
> Kundan Kumar (4):
>   writeback: prep helpers for dirty-limit and writeback accounting
>   f2fs: stop using writeback internals for dirty_exceeded checks
>   gfs2: stop using writeback internals for dirty_exceeded check
>   nfs: stop using writeback internals for WB_WRITEBACK accounting
> 
>  fs/f2fs/node.c              |  4 ++--
>  fs/f2fs/segment.h           |  2 +-
>  fs/gfs2/super.c             |  2 +-
>  fs/nfs/internal.h           |  2 +-
>  fs/nfs/write.c              |  4 ++--
>  include/linux/backing-dev.h | 11 +++++++++++
>  6 files changed, 18 insertions(+), 7 deletions(-)
> 
> 
> base-commit: 05f7e89ab9731565d8a62e3b5d1ec206485eeb0b

Seems sensible.

Reviewed-by: Jeff Layton <jlayton@kernel.org>

Re: [PATCH 0/4] Avoid filesystem references to writeback internals

Posted by Christoph Hellwig 1 month, 2 weeks ago

Looks fine as a cleanup, but maybe add comments that these functions
must not be used by file systems that support cgroup writeback and
thus can have multiple bdi_writeback structures per bdi?

Re: [PATCH 0/4] Avoid filesystem references to writeback internals

Posted by Andreas Gruenbacher 1 month, 2 weeks ago

On Wed, Feb 11, 2026 at 8:13 AM Kundan Kumar <kundan.kumar@samsung.com> wrote:
> The series introduces writeback helper APIs and converts f2fs, gfs2
> and nfs to stop accessing writeback internals directly.
>
> As suggested by Christoph [1], filesystem code that directly accesses
> writeback internals is split out:
> [1] https://lore.kernel.org/all/20251015072912.GA11294@lst.de/
>
> No functional changes intended
>
> Kundan Kumar (4):
>   writeback: prep helpers for dirty-limit and writeback accounting
>   f2fs: stop using writeback internals for dirty_exceeded checks
>   gfs2: stop using writeback internals for dirty_exceeded check
>   nfs: stop using writeback internals for WB_WRITEBACK accounting
>
>  fs/f2fs/node.c              |  4 ++--
>  fs/f2fs/segment.h           |  2 +-
>  fs/gfs2/super.c             |  2 +-
>  fs/nfs/internal.h           |  2 +-
>  fs/nfs/write.c              |  4 ++--
>  include/linux/backing-dev.h | 11 +++++++++++
>  6 files changed, 18 insertions(+), 7 deletions(-)
>
>
> base-commit: 05f7e89ab9731565d8a62e3b5d1ec206485eeb0b

Sure, that won't hurt.

Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>