[PATCH] selftests/mm: Remove duplicate include of unistd.h

Chen Ni posted 1 patch 1 month, 2 weeks ago
tools/testing/selftests/mm/memory-failure.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] selftests/mm: Remove duplicate include of unistd.h
Posted by Chen Ni 1 month, 2 weeks ago
Remove duplicate inclusion of unistd.h in memory-failure.c to clean up
redundant code.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 tools/testing/selftests/mm/memory-failure.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/mm/memory-failure.c b/tools/testing/selftests/mm/memory-failure.c
index 3d9e0b9ffb41..032ed952057c 100644
--- a/tools/testing/selftests/mm/memory-failure.c
+++ b/tools/testing/selftests/mm/memory-failure.c
@@ -13,7 +13,6 @@
 #include <unistd.h>
 #include <signal.h>
 #include <setjmp.h>
-#include <unistd.h>
 #include <fcntl.h>
 #include <sys/vfs.h>
 #include <linux/magic.h>
-- 
2.25.1
Re: [PATCH] selftests/mm: Remove duplicate include of unistd.h
Posted by Dev Jain 1 month, 2 weeks ago
On 11/02/26 12:13 pm, Chen Ni wrote:
> Remove duplicate inclusion of unistd.h in memory-failure.c to clean up
> redundant code.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---

Reviewed-by: Dev Jain <dev.jain@arm.com>

>  tools/testing/selftests/mm/memory-failure.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/memory-failure.c b/tools/testing/selftests/mm/memory-failure.c
> index 3d9e0b9ffb41..032ed952057c 100644
> --- a/tools/testing/selftests/mm/memory-failure.c
> +++ b/tools/testing/selftests/mm/memory-failure.c
> @@ -13,7 +13,6 @@
>  #include <unistd.h>
>  #include <signal.h>
>  #include <setjmp.h>
> -#include <unistd.h>
>  #include <fcntl.h>
>  #include <sys/vfs.h>
>  #include <linux/magic.h>
Re: [PATCH] selftests/mm: Remove duplicate include of unistd.h
Posted by Liam R. Howlett 1 month, 2 weeks ago
* Chen Ni <nichen@iscas.ac.cn> [260211 01:44]:
> Remove duplicate inclusion of unistd.h in memory-failure.c to clean up
> redundant code.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>


> ---
>  tools/testing/selftests/mm/memory-failure.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/memory-failure.c b/tools/testing/selftests/mm/memory-failure.c
> index 3d9e0b9ffb41..032ed952057c 100644
> --- a/tools/testing/selftests/mm/memory-failure.c
> +++ b/tools/testing/selftests/mm/memory-failure.c
> @@ -13,7 +13,6 @@
>  #include <unistd.h>
>  #include <signal.h>
>  #include <setjmp.h>
> -#include <unistd.h>
>  #include <fcntl.h>
>  #include <sys/vfs.h>
>  #include <linux/magic.h>
> -- 
> 2.25.1
>
Re: [PATCH] selftests/mm: Remove duplicate include of unistd.h
Posted by Miaohe Lin 1 month, 2 weeks ago
On 2026/2/11 14:43, Chen Ni wrote:
> Remove duplicate inclusion of unistd.h in memory-failure.c to clean up
> redundant code.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Oh, I missed that. Thanks.

Acked-by: Miaohe Lin <linmiaohe@huawei.com>

Thanks.
.
Re: [PATCH] selftests/mm: Remove duplicate include of unistd.h
Posted by SeongJae Park 1 month, 2 weeks ago
On Wed, 11 Feb 2026 14:43:11 +0800 Chen Ni <nichen@iscas.ac.cn> wrote:

> Remove duplicate inclusion of unistd.h in memory-failure.c to clean up
> redundant code.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]