[v3] lib: Rust implementation of SPDM

[RFC v3 06/27] rust: add bindings for hash.h

Posted by alistair23@gmail.com 1 month, 2 weeks ago

From: Alistair Francis <alistair.francis@wdc.com>

Make the functions crypto_shash_descsize(), crypto_shash_digestsize()
and crypto_free_shash() available to Rust.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 rust/bindings/bindings_helper.h |  2 ++
 rust/helpers/hash.c             | 18 ++++++++++++++++++
 rust/helpers/helpers.c          |  1 +
 3 files changed, 21 insertions(+)
 create mode 100644 rust/helpers/hash.c

diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
index a067038b4b42..0075c4b62c29 100644
--- a/rust/bindings/bindings_helper.h
+++ b/rust/bindings/bindings_helper.h
@@ -34,6 +34,7 @@
 #include <drm/drm_file.h>
 #include <drm/drm_gem.h>
 #include <drm/drm_ioctl.h>
+#include <crypto/hash.h>
 #include <kunit/test.h>
 #include <linux/auxiliary_bus.h>
 #include <linux/bitmap.h>
@@ -60,6 +61,7 @@
 #include <linux/fs.h>
 #include <linux/i2c.h>
 #include <linux/ioport.h>
+#include <linux/hash.h>
 #include <linux/jiffies.h>
 #include <linux/jump_label.h>
 #include <linux/mdio.h>
diff --git a/rust/helpers/hash.c b/rust/helpers/hash.c
new file mode 100644
index 000000000000..8ddb84668841
--- /dev/null
+++ b/rust/helpers/hash.c
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#include <crypto/hash.h>
+
+unsigned int rust_helper_crypto_shash_descsize(struct crypto_shash *tfm)
+{
+	return crypto_shash_descsize(tfm);
+}
+
+unsigned int rust_helper_crypto_shash_digestsize(struct crypto_shash *tfm)
+{
+	return crypto_shash_digestsize(tfm);
+}
+
+void rust_helper_crypto_free_shash(struct crypto_shash *tfm)
+{
+	crypto_free_shash(tfm);
+}
diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c
index a3c42e51f00a..4b08b4f1d3a3 100644
--- a/rust/helpers/helpers.c
+++ b/rust/helpers/helpers.c
@@ -30,6 +30,7 @@
 #include "dma.c"
 #include "drm.c"
 #include "err.c"
+#include "hash.c"
 #include "irq.c"
 #include "fs.c"
 #include "io.c"
-- 
2.52.0

Re: [RFC v3 06/27] rust: add bindings for hash.h

Posted by Jonathan Cameron 1 month ago

On Wed, 11 Feb 2026 13:29:13 +1000
alistair23@gmail.com wrote:

> From: Alistair Francis <alistair.francis@wdc.com>
> 
> Make the functions crypto_shash_descsize(), crypto_shash_digestsize()
> and crypto_free_shash() available to Rust.
> 
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>  rust/bindings/bindings_helper.h |  2 ++
>  rust/helpers/hash.c             | 18 ++++++++++++++++++
>  rust/helpers/helpers.c          |  1 +
>  3 files changed, 21 insertions(+)
>  create mode 100644 rust/helpers/hash.c
> 
> diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
> index a067038b4b42..0075c4b62c29 100644
> --- a/rust/bindings/bindings_helper.h
> +++ b/rust/bindings/bindings_helper.h
> @@ -34,6 +34,7 @@
>  #include <drm/drm_file.h>
>  #include <drm/drm_gem.h>
>  #include <drm/drm_ioctl.h>
> +#include <crypto/hash.h>

I'm not sure on ordering conventions but this feels odd..
Maybe before the drm inclues?

>  #include <kunit/test.h>
>  #include <linux/auxiliary_bus.h>
>  #include <linux/bitmap.h>
> @@ -60,6 +61,7 @@

Re: [RFC v3 06/27] rust: add bindings for hash.h

Posted by Gary Guo 1 month, 1 week ago

On 2026-02-11 03:29, alistair23@gmail.com wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
> 
> Make the functions crypto_shash_descsize(), crypto_shash_digestsize()
> and crypto_free_shash() available to Rust.
> 
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>  rust/bindings/bindings_helper.h |  2 ++
>  rust/helpers/hash.c             | 18 ++++++++++++++++++
>  rust/helpers/helpers.c          |  1 +
>  3 files changed, 21 insertions(+)
>  create mode 100644 rust/helpers/hash.c
> 
> diff --git a/rust/bindings/bindings_helper.h 
> b/rust/bindings/bindings_helper.h
> index a067038b4b42..0075c4b62c29 100644
> --- a/rust/bindings/bindings_helper.h
> +++ b/rust/bindings/bindings_helper.h
> @@ -34,6 +34,7 @@
>  #include <drm/drm_file.h>
>  #include <drm/drm_gem.h>
>  #include <drm/drm_ioctl.h>
> +#include <crypto/hash.h>
>  #include <kunit/test.h>
>  #include <linux/auxiliary_bus.h>
>  #include <linux/bitmap.h>
> @@ -60,6 +61,7 @@
>  #include <linux/fs.h>
>  #include <linux/i2c.h>
>  #include <linux/ioport.h>
> +#include <linux/hash.h>
>  #include <linux/jiffies.h>
>  #include <linux/jump_label.h>
>  #include <linux/mdio.h>
> diff --git a/rust/helpers/hash.c b/rust/helpers/hash.c
> new file mode 100644
> index 000000000000..8ddb84668841
> --- /dev/null
> +++ b/rust/helpers/hash.c
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <crypto/hash.h>
> +
> +unsigned int rust_helper_crypto_shash_descsize(struct crypto_shash 
> *tfm)

Please prefix all helpers with __rust_helper.

Same for patch 26.

Best,
Gary

> +{
> +	return crypto_shash_descsize(tfm);
> +}
> +
> +unsigned int rust_helper_crypto_shash_digestsize(struct crypto_shash 
> *tfm)
> +{
> +	return crypto_shash_digestsize(tfm);
> +}
> +
> +void rust_helper_crypto_free_shash(struct crypto_shash *tfm)
> +{
> +	crypto_free_shash(tfm);
> +}
> diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c
> index a3c42e51f00a..4b08b4f1d3a3 100644
> --- a/rust/helpers/helpers.c
> +++ b/rust/helpers/helpers.c
> @@ -30,6 +30,7 @@
>  #include "dma.c"
>  #include "drm.c"
>  #include "err.c"
> +#include "hash.c"
>  #include "irq.c"
>  #include "fs.c"
>  #include "io.c"