[PATCH v1 1/2] dt-bindings: display: tegra: document Tegra20 HDMI port

Svyatoslav Ryhel posted 2 patches 1 month, 3 weeks ago
There is a newer version of this series
[PATCH v1 1/2] dt-bindings: display: tegra: document Tegra20 HDMI port
Posted by Svyatoslav Ryhel 1 month, 3 weeks ago
Tegra HDMI can be modeled using an OF graph. Reflect this in the bindings.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 .../bindings/display/tegra/nvidia,tegra20-hdmi.yaml | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
index f77197e4869f..f33b700bf0ee 100644
--- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
+++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
@@ -82,6 +82,10 @@ properties:
     description: phandle of a display panel
     $ref: /schemas/types.yaml#/definitions/phandle
 
+  port:
+    description: connection to controller receiving HDMI signals
+    $ref: /schemas/graph.yaml#/properties/port
+
   "#sound-dai-cells":
     const: 0
 
@@ -97,8 +101,13 @@ required:
   - reset-names
   - pll-supply
   - vdd-supply
-  - nvidia,ddc-i2c-bus
-  - nvidia,hpd-gpio
+
+anyOf:
+  - required:
+    - nvidia,ddc-i2c-bus
+    - nvidia,hpd-gpio
+  - required:
+    - port
 
 examples:
   - |
-- 
2.51.0
Re: [PATCH v1 1/2] dt-bindings: display: tegra: document Tegra20 HDMI port
Posted by Rob Herring 1 month, 2 weeks ago
On Tue, Feb 10, 2026 at 11:49:07AM +0200, Svyatoslav Ryhel wrote:
> Tegra HDMI can be modeled using an OF graph. Reflect this in the bindings.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  .../bindings/display/tegra/nvidia,tegra20-hdmi.yaml | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
> index f77197e4869f..f33b700bf0ee 100644
> --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
> @@ -82,6 +82,10 @@ properties:
>      description: phandle of a display panel
>      $ref: /schemas/types.yaml#/definitions/phandle
>  
> +  port:
> +    description: connection to controller receiving HDMI signals

Describe this in terms of this block, not what it is connected to. It 
could be an hdmi-connector node or a bridge.

> +    $ref: /schemas/graph.yaml#/properties/port
> +
>    "#sound-dai-cells":
>      const: 0
>  
> @@ -97,8 +101,13 @@ required:
>    - reset-names
>    - pll-supply
>    - vdd-supply
> -  - nvidia,ddc-i2c-bus
> -  - nvidia,hpd-gpio
> +
> +anyOf:
> +  - required:
> +    - nvidia,ddc-i2c-bus
> +    - nvidia,hpd-gpio
> +  - required:
> +    - port
>  
>  examples:
>    - |
> -- 
> 2.51.0
>
Re: [PATCH v1 1/2] dt-bindings: display: tegra: document Tegra20 HDMI port
Posted by Svyatoslav Ryhel 1 month, 2 weeks ago

10 лютого 2026 р. 16:19:17 GMT+02:00, Rob Herring <robh@kernel.org> пише:
>On Tue, Feb 10, 2026 at 11:49:07AM +0200, Svyatoslav Ryhel wrote:
>> Tegra HDMI can be modeled using an OF graph. Reflect this in the bindings.
>> 
>> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
>> ---
>>  .../bindings/display/tegra/nvidia,tegra20-hdmi.yaml | 13 +++++++++++--
>>  1 file changed, 11 insertions(+), 2 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
>> index f77197e4869f..f33b700bf0ee 100644
>> --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
>> +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml
>> @@ -82,6 +82,10 @@ properties:
>>      description: phandle of a display panel
>>      $ref: /schemas/types.yaml#/definitions/phandle
>>  
>> +  port:
>> +    description: connection to controller receiving HDMI signals
>
>Describe this in terms of this block, not what it is connected to. It 
>could be an hdmi-connector node or a bridge.
>

Isn't the idea of port to provide connection to the remove device. How should I word it: "links HDMI host with the receiver" or "output of HDMI"? I don't quite understand what you mean. Maybe I should remove description entirely, HDMI has a single port and its function is pretty strait forward.

>> +    $ref: /schemas/graph.yaml#/properties/port
>> +
>>    "#sound-dai-cells":
>>      const: 0
>>  
>> @@ -97,8 +101,13 @@ required:
>>    - reset-names
>>    - pll-supply
>>    - vdd-supply
>> -  - nvidia,ddc-i2c-bus
>> -  - nvidia,hpd-gpio
>> +
>> +anyOf:
>> +  - required:
>> +    - nvidia,ddc-i2c-bus
>> +    - nvidia,hpd-gpio
>> +  - required:
>> +    - port
>>  
>>  examples:
>>    - |
>> -- 
>> 2.51.0
>> 
Re: [PATCH v1 1/2] dt-bindings: display: tegra: document Tegra20 HDMI port
Posted by Rob Herring (Arm) 1 month, 3 weeks ago
On Tue, 10 Feb 2026 11:49:07 +0200, Svyatoslav Ryhel wrote:
> Tegra HDMI can be modeled using an OF graph. Reflect this in the bindings.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  .../bindings/display/tegra/nvidia,tegra20-hdmi.yaml | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml:107:5: [warning] wrong indentation: expected 6 but found 4 (indentation)
./Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-hdmi.yaml:110:5: [warning] wrong indentation: expected 6 but found 4 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260210094908.14276-2-clamor95@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.