1. Patchew
  2. linux
  3. [PATCH v7 0/6] iio: adc: ad9467: Support alternative backends
  4. View patch

[PATCH v7 5/6] iio: adc: ad9467: simplify device pointer in probe

Tomas Melin posted 6 patches 18 hours ago
[PATCH v7 5/6] iio: adc: ad9467: simplify device pointer in probe
Posted by Tomas Melin 18 hours ago 
Create alias for the device pointer to simplify referencing
and keeping syntax and column width shorter.

Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
---
 drivers/iio/adc/ad9467.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c
index 59c3fa3bcc9b..ae9139290c22 100644
--- a/drivers/iio/adc/ad9467.c
+++ b/drivers/iio/adc/ad9467.c
@@ -1283,12 +1283,13 @@ static void ad9467_debugfs_init(struct iio_dev *indio_dev)
 
 static int ad9467_probe(struct spi_device *spi)
 {
+	struct device *dev = &spi->dev;
 	struct iio_dev *indio_dev;
 	struct ad9467_state *st;
 	unsigned int id;
 	int ret;
 
-	indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
+	indio_dev = devm_iio_device_alloc(dev, sizeof(*st));
 	if (!indio_dev)
 		return -ENOMEM;
 
@@ -1303,16 +1304,16 @@ static int ad9467_probe(struct spi_device *spi)
 	if (AD9467_CAN_INVERT(st))
 		st->calib_map_size *= 2;
 
-	st->clk = devm_clk_get_enabled(&spi->dev, "adc-clk");
+	st->clk = devm_clk_get_enabled(dev, "adc-clk");
 	if (IS_ERR(st->clk))
 		return PTR_ERR(st->clk);
 
-	st->pwrdown_gpio = devm_gpiod_get_optional(&spi->dev, "powerdown",
+	st->pwrdown_gpio = devm_gpiod_get_optional(dev, "powerdown",
 						   GPIOD_OUT_LOW);
 	if (IS_ERR(st->pwrdown_gpio))
 		return PTR_ERR(st->pwrdown_gpio);
 
-	ret = ad9467_reset(&spi->dev);
+	ret = ad9467_reset(dev);
 	if (ret)
 		return ret;
 
@@ -1322,8 +1323,8 @@ static int ad9467_probe(struct spi_device *spi)
 
 	id = ad9467_spi_read(st, AN877_ADC_REG_CHIP_ID);
 	if (id != st->info->id) {
-		dev_err(&spi->dev, "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n",
-			id, st->info->id);
+		dev_err(dev, "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n", id,
+			st->info->id);
 		return -ENODEV;
 	}
 
@@ -1339,11 +1340,11 @@ static int ad9467_probe(struct spi_device *spi)
 	if (ret)
 		return ret;
 
-	ret = devm_iio_backend_request_buffer(&spi->dev, st->back, indio_dev);
+	ret = devm_iio_backend_request_buffer(dev, st->back, indio_dev);
 	if (ret)
 		return ret;
 
-	ret = devm_iio_backend_enable(&spi->dev, st->back);
+	ret = devm_iio_backend_enable(dev, st->back);
 	if (ret)
 		return ret;
 
@@ -1351,7 +1352,7 @@ static int ad9467_probe(struct spi_device *spi)
 	if (ret)
 		return ret;
 
-	ret = devm_iio_device_register(&spi->dev, indio_dev);
+	ret = devm_iio_device_register(dev, indio_dev);
 	if (ret)
 		return ret;
 

-- 
2.47.3
Re: [PATCH v7 5/6] iio: adc: ad9467: simplify device pointer in probe
Posted by Andy Shevchenko 14 hours ago 
On Tue, Feb 10, 2026 at 10:53:38AM +0000, Tomas Melin wrote:
> Create alias for the device pointer to simplify referencing
> and keeping syntax and column width shorter.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

Some nit-picks in case it will be a new version or Jonathan will be keen to
tweak it.

...

> -	st->pwrdown_gpio = devm_gpiod_get_optional(&spi->dev, "powerdown",
> +	st->pwrdown_gpio = devm_gpiod_get_optional(dev, "powerdown",
>  						   GPIOD_OUT_LOW);

I would dare to make it a single line.

>  	if (IS_ERR(st->pwrdown_gpio))
>  		return PTR_ERR(st->pwrdown_gpio);

...

> -		dev_err(&spi->dev, "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n",
> -			id, st->info->id);
> +		dev_err(dev, "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n", id,

> +			st->info->id);

I would not touch the second line as it makes a logical split.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v7 5/6] iio: adc: ad9467: simplify device pointer in probe
Posted by Nuno Sá 17 hours ago 
On Tue, 2026-02-10 at 10:53 +0000, Tomas Melin wrote:
> Create alias for the device pointer to simplify referencing
> and keeping syntax and column width shorter.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
> ---

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

>  drivers/iio/adc/ad9467.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c
> index 59c3fa3bcc9b..ae9139290c22 100644
> --- a/drivers/iio/adc/ad9467.c
> +++ b/drivers/iio/adc/ad9467.c
> @@ -1283,12 +1283,13 @@ static void ad9467_debugfs_init(struct iio_dev *indio_dev)
>  
>  static int ad9467_probe(struct spi_device *spi)
>  {
> +	struct device *dev = &spi->dev;
>  	struct iio_dev *indio_dev;
>  	struct ad9467_state *st;
>  	unsigned int id;
>  	int ret;
>  
> -	indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
> +	indio_dev = devm_iio_device_alloc(dev, sizeof(*st));
>  	if (!indio_dev)
>  		return -ENOMEM;
>  
> @@ -1303,16 +1304,16 @@ static int ad9467_probe(struct spi_device *spi)
>  	if (AD9467_CAN_INVERT(st))
>  		st->calib_map_size *= 2;
>  
> -	st->clk = devm_clk_get_enabled(&spi->dev, "adc-clk");
> +	st->clk = devm_clk_get_enabled(dev, "adc-clk");
>  	if (IS_ERR(st->clk))
>  		return PTR_ERR(st->clk);
>  
> -	st->pwrdown_gpio = devm_gpiod_get_optional(&spi->dev, "powerdown",
> +	st->pwrdown_gpio = devm_gpiod_get_optional(dev, "powerdown",
>  						   GPIOD_OUT_LOW);
>  	if (IS_ERR(st->pwrdown_gpio))
>  		return PTR_ERR(st->pwrdown_gpio);
>  
> -	ret = ad9467_reset(&spi->dev);
> +	ret = ad9467_reset(dev);
>  	if (ret)
>  		return ret;
>  
> @@ -1322,8 +1323,8 @@ static int ad9467_probe(struct spi_device *spi)
>  
>  	id = ad9467_spi_read(st, AN877_ADC_REG_CHIP_ID);
>  	if (id != st->info->id) {
> -		dev_err(&spi->dev, "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n",
> -			id, st->info->id);
> +		dev_err(dev, "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n", id,
> +			st->info->id);
>  		return -ENODEV;
>  	}
>  
> @@ -1339,11 +1340,11 @@ static int ad9467_probe(struct spi_device *spi)
>  	if (ret)
>  		return ret;
>  
> -	ret = devm_iio_backend_request_buffer(&spi->dev, st->back, indio_dev);
> +	ret = devm_iio_backend_request_buffer(dev, st->back, indio_dev);
>  	if (ret)
>  		return ret;
>  
> -	ret = devm_iio_backend_enable(&spi->dev, st->back);
> +	ret = devm_iio_backend_enable(dev, st->back);
>  	if (ret)
>  		return ret;
>  
> @@ -1351,7 +1352,7 @@ static int ad9467_probe(struct spi_device *spi)
>  	if (ret)
>  		return ret;
>  
> -	ret = devm_iio_device_register(&spi->dev, indio_dev);
> +	ret = devm_iio_device_register(dev, indio_dev);
>  	if (ret)
>  		return ret;
>  

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.