Remove "== true" comparisons with boolean variables. Should improve
readability.
Signed-off-by: Adarsh Das <adarshdas950@gmail.com>
---
fs/smb/client/connect.c | 4 ++--
fs/smb/client/misc.c | 2 +-
fs/smb/client/smb2ops.c | 4 ++--
fs/smb/server/server.c | 2 +-
fs/smb/server/smb2pdu.c | 12 ++++++------
fs/smb/server/vfs.c | 8 ++++----
fs/smb/server/vfs_cache.c | 2 +-
7 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c
index ce620503e9f7..75137359757d 100644
--- a/fs/smb/client/connect.c
+++ b/fs/smb/client/connect.c
@@ -962,7 +962,7 @@ dequeue_mid(struct TCP_Server_Info *server, struct mid_q_entry *mid, bool malfor
* Trying to handle/dequeue a mid after the send_recv()
* function has finished processing it is a bug.
*/
- if (mid->deleted_from_q == true) {
+ if (mid->deleted_from_q) {
spin_unlock(&server->mid_queue_lock);
pr_warn_once("trying to dequeue a deleted mid\n");
} else {
@@ -3675,7 +3675,7 @@ int cifs_mount_get_session(struct cifs_mount_ctx *mnt_ctx)
goto out;
}
- if ((ctx->persistent == true) && (!(ses->server->capabilities &
+ if (ctx->persistent && (!(ses->server->capabilities &
SMB2_GLOBAL_CAP_PERSISTENT_HANDLES))) {
cifs_server_dbg(VFS, "persistent handles not supported by server\n");
rc = -EOPNOTSUPP;
diff --git a/fs/smb/client/misc.c b/fs/smb/client/misc.c
index 9529fa385938..bc5b74bdcb4e 100644
--- a/fs/smb/client/misc.c
+++ b/fs/smb/client/misc.c
@@ -122,7 +122,7 @@ tcon_info_alloc(bool dir_leases_enabled, enum smb3_tcon_ref_trace trace)
if (!ret_buf)
return NULL;
- if (dir_leases_enabled == true) {
+ if (dir_leases_enabled) {
ret_buf->cfids = init_cached_dirs();
if (!ret_buf->cfids) {
kfree(ret_buf);
diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
index c1aaf77e187b..edf5afb2ddd2 100644
--- a/fs/smb/client/smb2ops.c
+++ b/fs/smb/client/smb2ops.c
@@ -3681,7 +3681,7 @@ static long smb3_simple_falloc(struct file *file, struct cifs_tcon *tcon,
goto out;
}
- if (keep_size == true) {
+ if (keep_size) {
/*
* We can not preallocate pages beyond the end of the file
* in SMB2
@@ -3699,7 +3699,7 @@ static long smb3_simple_falloc(struct file *file, struct cifs_tcon *tcon,
}
}
- if ((keep_size == true) || (i_size_read(inode) >= off + len)) {
+ if (keep_size || (i_size_read(inode) >= off + len)) {
/*
* At this point, we are trying to fallocate an internal
* regions of a sparse file. Since smb2 does not have a
diff --git a/fs/smb/server/server.c b/fs/smb/server/server.c
index 554ae90df906..78e68a7a618a 100644
--- a/fs/smb/server/server.c
+++ b/fs/smb/server/server.c
@@ -235,7 +235,7 @@ static void __handle_ksmbd_work(struct ksmbd_work *work,
(work->sess->sign || smb3_11_final_sess_setup_resp(work) ||
conn->ops->is_sign_req(work, command)))
conn->ops->set_sign_rsp(work);
- } while (is_chained == true);
+ } while (is_chained);
send:
if (work->tcon)
diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
index 2fcd0d4d1fb0..de40ef7ac26a 100644
--- a/fs/smb/server/smb2pdu.c
+++ b/fs/smb/server/smb2pdu.c
@@ -2601,7 +2601,7 @@ static int smb2_creat(struct ksmbd_work *work,
return -EBADF;
ksmbd_debug(SMB, "file does not exist, so creating\n");
- if (is_dir == true) {
+ if (is_dir) {
ksmbd_debug(SMB, "creating directory\n");
mode = share_config_directory_mode(share, posix_mode);
@@ -2987,7 +2987,7 @@ int smb2_open(struct ksmbd_work *work)
goto err_out2;
}
- if (dh_info.reconnected == true) {
+ if (dh_info.reconnected) {
rc = smb2_check_durable_oplock(conn, share, dh_info.fp, lc, name);
if (rc) {
ksmbd_put_durable_fd(dh_info.fp);
@@ -6222,7 +6222,7 @@ static int set_file_allocation_info(struct ksmbd_work *work,
if (!(fp->daccess & FILE_WRITE_DATA_LE))
return -EACCES;
- if (ksmbd_stream_fd(fp) == true)
+ if (ksmbd_stream_fd(fp))
return 0;
rc = vfs_getattr(&fp->filp->f_path, &stat, STATX_BASIC_STATS,
@@ -6779,7 +6779,7 @@ int smb2_read(struct ksmbd_work *work)
}
}
- if (is_rdma_channel == true) {
+ if (is_rdma_channel) {
unsigned int ch_offset = le16_to_cpu(req->ReadChannelInfoOffset);
if (ch_offset < offsetof(struct smb2_read_req, Buffer)) {
@@ -6849,7 +6849,7 @@ int smb2_read(struct ksmbd_work *work)
ksmbd_debug(SMB, "nbytes %zu, offset %lld mincount %zu\n",
nbytes, offset, mincount);
- if (is_rdma_channel == true) {
+ if (is_rdma_channel) {
/* write data to the client using rdma channel */
remain_bytes = smb2_read_rdma_channel(work, req,
aux_payload_buf,
@@ -7043,7 +7043,7 @@ int smb2_write(struct ksmbd_work *work)
length = le32_to_cpu(req->RemainingBytes);
}
- if (is_rdma_channel == true) {
+ if (is_rdma_channel) {
unsigned int ch_offset = le16_to_cpu(req->WriteChannelInfoOffset);
if (req->Length != 0 || req->DataOffset != 0 ||
diff --git a/fs/smb/server/vfs.c b/fs/smb/server/vfs.c
index b8e648b8300f..6e6ad5eda9ea 100644
--- a/fs/smb/server/vfs.c
+++ b/fs/smb/server/vfs.c
@@ -877,7 +877,7 @@ int ksmbd_vfs_setxattr(struct mnt_idmap *idmap,
{
int err;
- if (get_write == true) {
+ if (get_write) {
err = mnt_want_write(path->mnt);
if (err)
return err;
@@ -891,7 +891,7 @@ int ksmbd_vfs_setxattr(struct mnt_idmap *idmap,
flags);
if (err)
ksmbd_debug(VFS, "setxattr failed, err %d\n", err);
- if (get_write == true)
+ if (get_write)
mnt_drop_write(path->mnt);
return err;
}
@@ -1001,7 +1001,7 @@ int ksmbd_vfs_remove_xattr(struct mnt_idmap *idmap,
{
int err;
- if (get_write == true) {
+ if (get_write) {
err = mnt_want_write(path->mnt);
if (err)
return err;
@@ -1009,7 +1009,7 @@ int ksmbd_vfs_remove_xattr(struct mnt_idmap *idmap,
err = vfs_removexattr(idmap, path->dentry, attr_name);
- if (get_write == true)
+ if (get_write)
mnt_drop_write(path->mnt);
return err;
diff --git a/fs/smb/server/vfs_cache.c b/fs/smb/server/vfs_cache.c
index 6ef116585af6..ea9c237b2bca 100644
--- a/fs/smb/server/vfs_cache.c
+++ b/fs/smb/server/vfs_cache.c
@@ -863,7 +863,7 @@ void ksmbd_launch_ksmbd_durable_scavenger(void)
return;
mutex_lock(&durable_scavenger_lock);
- if (durable_scavenger_running == true) {
+ if (durable_scavenger_running) {
mutex_unlock(&durable_scavenger_lock);
return;
}
--
2.53.0
© 2016 - 2026 Red Hat, Inc.