Fix checkpatch.pl checks:
CHECK: Unbalanced braces around else statement
CHECK: braces {} should be used on all arms of this statement
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Matt Wardle <matt@mattwardle.net>
---
.../staging/media/atomisp/pci/base/refcount/src/refcount.c | 7 ++++---
drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c | 6 ++++--
drivers/staging/media/atomisp/pci/sh_css.c | 1 -
drivers/staging/media/atomisp/pci/sh_css_sp.c | 3 ++-
4 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c b/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c
index 4a8675d0129a..65dda74614f6 100644
--- a/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c
+++ b/drivers/staging/media/atomisp/pci/base/refcount/src/refcount.c
@@ -140,13 +140,14 @@ ia_css_ptr ia_css_refcount_increment(s32 id, ia_css_ptr ptr)
return mmgr_NULL;
}
- if (entry->data == ptr)
+ if (entry->data == ptr) {
entry->count += 1;
- else if (entry->data == mmgr_NULL) {
+ } else if (entry->data == mmgr_NULL) {
entry->data = ptr;
entry->count = 1;
- } else
+ } else {
return mmgr_NULL;
+ }
return ptr;
}
diff --git a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
index 9cfb8bc97e24..66e72f2ce288 100644
--- a/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
+++ b/drivers/staging/media/atomisp/pci/runtime/isys/src/rx.c
@@ -484,13 +484,15 @@ int ia_css_isys_convert_compressed_format(
default:
err = -EINVAL;
}
- } else
+ } else {
err = -EINVAL;
+ }
cfg->csi_port_attr.comp_predictor =
sh_css_csi2_compression_type_2_mipi_predictor(comp->type);
cfg->csi_port_attr.comp_enable = true;
- } else /* No compression */
+ } else { /* No compression */
cfg->csi_port_attr.comp_enable = false;
+ }
return err;
}
diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/media/atomisp/pci/sh_css.c
index e7f2443696d1..27b552501e7f 100644
--- a/drivers/staging/media/atomisp/pci/sh_css.c
+++ b/drivers/staging/media/atomisp/pci/sh_css.c
@@ -3520,7 +3520,6 @@ ia_css_pipe_enqueue_buffer(struct ia_css_pipe *pipe,
ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE,
"ia_css_pipe_enqueue_buffer() buf_type=%d, data(DDR address)=0x%x\n",
buf_type, buffer->data.frame->data);
-
}
/* start of test for using rmgr for acq/rel memory */
diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c
index 6da151e7a873..0fb6a90fcbcb 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_sp.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_sp.c
@@ -1484,10 +1484,11 @@ sh_css_update_host2sp_cont_num_raw_frames(unsigned int num_frames,
host2sp_cont_extra_num_raw_frames)
/ sizeof(int);
store_sp_array_uint(host_sp_com, offset_extra, extra_num_frames);
- } else
+ } else {
offset = (unsigned int)offsetof(struct host_sp_communication,
host2sp_cont_target_num_raw_frames)
/ sizeof(int);
+ }
store_sp_array_uint(host_sp_com, offset, num_frames);
}
--
2.53.0
On Mon, Feb 09, 2026 at 02:29:28PM +0000, Matt Wardle wrote:
> Fix checkpatch.pl checks:
>
> CHECK: Unbalanced braces around else statement
> CHECK: braces {} should be used on all arms of this statement
> CHECK: Blank lines aren't necessary before a close brace '}'
OK, but I think this one can wait. This most likely doesn't affect readability
in any better way (so, w/o this patch it's not worse than after).
--
With Best Regards,
Andy Shevchenko
© 2016 - 2026 Red Hat, Inc.