[PATCH 1/2] staging: media: atomisp: fix block comment style in ov2722.h

Taekyung Oh posted 2 patches 14 hours ago
[PATCH 1/2] staging: media: atomisp: fix block comment style in ov2722.h
Posted by Taekyung Oh 14 hours ago
Fix coding style warnings reported by checkpatch.pl.
Move the comments above the corresponding code lines.

Signed-off-by: Taekyung Oh <ohxorud@ohxorud.com>
---
 drivers/staging/media/atomisp/i2c/ov2722.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/media/atomisp/i2c/ov2722.h b/drivers/staging/media/atomisp/i2c/ov2722.h
index 00317d105..c69f0086c 100644
--- a/drivers/staging/media/atomisp/i2c/ov2722.h
+++ b/drivers/staging/media/atomisp/i2c/ov2722.h
@@ -566,8 +566,8 @@ static const struct ov2722_reg ov2722_VGA_30fps[] = {
 #endif
 
 static const struct ov2722_reg ov2722_1632_1092_30fps[] = {
-	{OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for
-				a whole frame complete.(vblank) */
+    /* For stand wait for a whole frame complete.(vblank) */
+	{OV2722_8BIT, 0x3021, 0x03},
 	{OV2722_8BIT, 0x3718, 0x10},
 	{OV2722_8BIT, 0x3702, 0x24},
 	{OV2722_8BIT, 0x373a, 0x60},
@@ -668,8 +668,8 @@ static const struct ov2722_reg ov2722_1632_1092_30fps[] = {
 };
 
 static const struct ov2722_reg ov2722_1452_1092_30fps[] = {
-	{OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for
-				a whole frame complete.(vblank) */
+    /* For stand wait for a whole frame complete.(vblank) */
+	{OV2722_8BIT, 0x3021, 0x03},
 	{OV2722_8BIT, 0x3718, 0x10},
 	{OV2722_8BIT, 0x3702, 0x24},
 	{OV2722_8BIT, 0x373a, 0x60},
@@ -878,8 +878,8 @@ static const struct ov2722_reg ov2722_1M3_30fps[] = {
 #endif
 
 static const struct ov2722_reg ov2722_1080p_30fps[] = {
-	{OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for a whole
-					frame complete.(vblank) */
+    /* For stand wait for a whole frame complete.(vblank) */
+	{OV2722_8BIT, 0x3021, 0x03},
 	{OV2722_8BIT, 0x3718, 0x10},
 	{OV2722_8BIT, 0x3702, 0x24},
 	{OV2722_8BIT, 0x373a, 0x60},
-- 
2.50.1 (Apple Git-155)
Re: [PATCH 1/2] staging: media: atomisp: fix block comment style in ov2722.h
Posted by Greg Kroah-Hartman 13 hours ago
On Mon, Feb 09, 2026 at 04:55:53AM +0000, Taekyung Oh wrote:
> Fix coding style warnings reported by checkpatch.pl.
> Move the comments above the corresponding code lines.
> 
> Signed-off-by: Taekyung Oh <ohxorud@ohxorud.com>
> ---
>  drivers/staging/media/atomisp/i2c/ov2722.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/i2c/ov2722.h b/drivers/staging/media/atomisp/i2c/ov2722.h
> index 00317d105..c69f0086c 100644
> --- a/drivers/staging/media/atomisp/i2c/ov2722.h
> +++ b/drivers/staging/media/atomisp/i2c/ov2722.h
> @@ -566,8 +566,8 @@ static const struct ov2722_reg ov2722_VGA_30fps[] = {
>  #endif
>  
>  static const struct ov2722_reg ov2722_1632_1092_30fps[] = {
> -	{OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for
> -				a whole frame complete.(vblank) */
> +    /* For stand wait for a whole frame complete.(vblank) */
> +	{OV2722_8BIT, 0x3021, 0x03},

You now added a different coding style warning :(
Re: [PATCH 1/2] staging: media: atomisp: fix block comment style in ov2722.h
Posted by Taekyung Oh 3 hours ago
On Monday, February 9th, 2026 at 1:47 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > Fix coding style warnings reported by checkpatch.pl.
> > Move the comments above the corresponding code lines.
> > 
> > Signed-off-by: Taekyung Oh ohxorud@ohxorud.com
> > ---
> > drivers/staging/media/atomisp/i2c/ov2722.h | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/staging/media/atomisp/i2c/ov2722.h b/drivers/staging/media/atomisp/i2c/ov2722.h
> > index 00317d105..c69f0086c 100644
> > --- a/drivers/staging/media/atomisp/i2c/ov2722.h
> > +++ b/drivers/staging/media/atomisp/i2c/ov2722.h
> > @@ -566,8 +566,8 @@ static const struct ov2722_reg ov2722_VGA_30fps[] = {
> > #endif
> > 
> > static const struct ov2722_reg ov2722_1632_1092_30fps[] = {
> > - {OV2722_8BIT, 0x3021, 0x03}, /* For stand wait for
> > - a whole frame complete.(vblank) /
> > + / For stand wait for a whole frame complete.(vblank) */
> > + {OV2722_8BIT, 0x3021, 0x03},
> 
> 
> You now added a different coding style warning :(

Sorry, I made silly mistake as it's my first contribution to Linux.
I will fix tab style and send v2 shortly.