[PATCH v1] perf test record.sh: Fix shellcheck warning

Ian Rogers posted 1 patch 22 hours ago
tools/perf/tests/shell/record.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v1] perf test record.sh: Fix shellcheck warning
Posted by Ian Rogers 22 hours ago
Add quotes to avoid the following warning:
```
In tests/shell/record.sh line 264:
 [ $(uname -m) = "s390x" ] && {
   ^---------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
 https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
```

Fixes: c73a56ed3c97 ("perf test: Fix test case Leader sampling on s390")
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/tests/shell/record.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
index 46b96d565680..7cb81cf3444a 100755
--- a/tools/perf/tests/shell/record.sh
+++ b/tools/perf/tests/shell/record.sh
@@ -261,7 +261,7 @@ test_uid() {
 test_leader_sampling() {
   echo "Basic leader sampling test"
   events="{cycles,cycles}:Su"
-  [ $(uname -m) = "s390x" ] && {
+  [ "$(uname -m)" = "s390x" ] && {
     [ ! -d /sys/devices/cpum_sf ] && {
       echo "No CPUMF [Skipped record]"
       return
-- 
2.53.0.239.g8d8fc8a987-goog
Re: [PATCH v1] perf test record.sh: Fix shellcheck warning
Posted by Arnaldo Carvalho de Melo 6 hours ago
On Sat, Feb 07, 2026 at 03:04:52PM -0800, Ian Rogers wrote:
> Add quotes to avoid the following warning:
> ```
> In tests/shell/record.sh line 264:
>  [ $(uname -m) = "s390x" ] && {
>    ^---------^ SC2046 (warning): Quote this to prevent word splitting.
> 
> For more information:
>  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
> ```
> 
> Fixes: c73a56ed3c97 ("perf test: Fix test case Leader sampling on s390")

Thanks, applied to perf-tools-next,

- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/tests/shell/record.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> index 46b96d565680..7cb81cf3444a 100755
> --- a/tools/perf/tests/shell/record.sh
> +++ b/tools/perf/tests/shell/record.sh
> @@ -261,7 +261,7 @@ test_uid() {
>  test_leader_sampling() {
>    echo "Basic leader sampling test"
>    events="{cycles,cycles}:Su"
> -  [ $(uname -m) = "s390x" ] && {
> +  [ "$(uname -m)" = "s390x" ] && {
>      [ ! -d /sys/devices/cpum_sf ] && {
>        echo "No CPUMF [Skipped record]"
>        return
> -- 
> 2.53.0.239.g8d8fc8a987-goog
>