[PATCH] perf/x86/intel/uncore: Use sysfs_emit in uncore_event_show

Thorsten Blum posted 1 patch 13 hours ago
arch/x86/events/intel/uncore.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
[PATCH] perf/x86/intel/uncore: Use sysfs_emit in uncore_event_show
Posted by Thorsten Blum 13 hours ago
Replace sprintf() with sysfs_emit() in uncore_event_show(). sysfs_emit()
is preferred to format sysfs output as it provides better bounds
checking.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
checkpatch warns about a missing terminating newline. Please let me know
if this should be added.
---
 arch/x86/events/intel/uncore.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/events/intel/uncore.c b/arch/x86/events/intel/uncore.c
index e228e564b15e..532eb68d950b 100644
--- a/arch/x86/events/intel/uncore.c
+++ b/arch/x86/events/intel/uncore.c
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 #include <linux/module.h>
+#include <linux/sysfs.h>
 
 #include <asm/cpu_device_id.h>
 #include <asm/intel-family.h>
@@ -133,7 +134,7 @@ ssize_t uncore_event_show(struct device *dev,
 {
 	struct uncore_event_desc *event =
 		container_of(attr, struct uncore_event_desc, attr);
-	return sprintf(buf, "%s", event->config);
+	return sysfs_emit(buf, "%s", event->config);
 }
 
 struct intel_uncore_box *uncore_pmu_to_box(struct intel_uncore_pmu *pmu, int cpu)
-- 
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4