[PATCH] drm/rockchip: analogix_dp: Add missing error check for platform_get_resource()

Chen Ni posted 1 patch 2 days, 3 hours ago
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH] drm/rockchip: analogix_dp: Add missing error check for platform_get_resource()
Posted by Chen Ni 2 days, 3 hours ago
Add missing error check for platform_get_resource() return value to
prevent NULL pointer dereference when memory resource is not available.

Fixes: 718b3bb9c0ab ("drm/rockchip: analogix_dp: Expand device data to support multiple edp display")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index fdab71d51e2a..3f5be14010c1 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -461,6 +461,8 @@ static int rockchip_dp_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!res)
+		return -EINVAL;
 
 	i = 0;
 	while (dp_data[i].reg) {
-- 
2.25.1
Re: [PATCH] drm/rockchip: analogix_dp: Add missing error check for platform_get_resource()
Posted by Markus Elfring 1 day, 22 hours ago
> Add missing error check for platform_get_resource() return value to
> prevent NULL pointer dereference when memory resource is not available.

* Were any source code analysis tools involved here?

* See also once more:
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.19-rc8#n34


Regards,
Markus
Re: [PATCH] drm/rockchip: analogix_dp: Add missing error check forplatform_get_resource()
Posted by Dragan Simic 2 days, 2 hours ago
Hello Chen,

On Friday, February 06, 2026 09:42 CET, Chen Ni <nichen@iscas.ac.cn> wrote:
> Add missing error check for platform_get_resource() return value to
> prevent NULL pointer dereference when memory resource is not available.
> 
> Fixes: 718b3bb9c0ab ("drm/rockchip: analogix_dp: Expand device data to support multiple edp display")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> index fdab71d51e2a..3f5be14010c1 100644
> --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
> @@ -461,6 +461,8 @@ static int rockchip_dp_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res)
> +		return -EINVAL;
>  
>  	i = 0;
>  	while (dp_data[i].reg) {

Thanks for this patch!  It is looking good to me, but I think it should be
propagated into the stable kernels as well.

Please feel free to include

Reviewed-by: Dragan Simic <dsimic@manjaro.org>