[PATCH V1] accel/amdxdna: Switch to always use chained command

Lizhi Hou posted 1 patch 1 day, 3 hours ago
drivers/accel/amdxdna/aie2_ctx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH V1] accel/amdxdna: Switch to always use chained command
Posted by Lizhi Hou 1 day, 3 hours ago
Preempt commands are only supported when submitted as chained commands.
To ensure preempt support works consistently, always submit commands in
chained command format.

Set force_cmdlist to true so that single commands are filled using the
chained command layout, enabling correct handling of preempt commands.

Fixes: 3a0ff7b98af4 ("accel/amdxdna: Support preemption requests")
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
 drivers/accel/amdxdna/aie2_ctx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
index 37d05f2e986f..6378a0bc7b6e 100644
--- a/drivers/accel/amdxdna/aie2_ctx.c
+++ b/drivers/accel/amdxdna/aie2_ctx.c
@@ -23,9 +23,9 @@
 #include "amdxdna_pci_drv.h"
 #include "amdxdna_pm.h"
 
-static bool force_cmdlist;
+static bool force_cmdlist = true;
 module_param(force_cmdlist, bool, 0600);
-MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default false)");
+MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default true)");
 
 #define HWCTX_MAX_TIMEOUT	60000 /* milliseconds */
 
-- 
2.34.1
Re: [PATCH V1] accel/amdxdna: Switch to always use chained command
Posted by Mario Limonciello 19 hours ago

On 2/6/2026 12:02 AM, Lizhi Hou wrote:
> Preempt commands are only supported when submitted as chained commands.
> To ensure preempt support works consistently, always submit commands in
> chained command format.
> 
> Set force_cmdlist to true so that single commands are filled using the
> chained command layout, enabling correct handling of preempt commands.
> 
> Fixes: 3a0ff7b98af4 ("accel/amdxdna: Support preemption requests")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> ---
>   drivers/accel/amdxdna/aie2_ctx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
> index 37d05f2e986f..6378a0bc7b6e 100644
> --- a/drivers/accel/amdxdna/aie2_ctx.c
> +++ b/drivers/accel/amdxdna/aie2_ctx.c
> @@ -23,9 +23,9 @@
>   #include "amdxdna_pci_drv.h"
>   #include "amdxdna_pm.h"
>   
> -static bool force_cmdlist;
> +static bool force_cmdlist = true;
>   module_param(force_cmdlist, bool, 0600);
> -MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default false)");
> +MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default true)");
>   
>   #define HWCTX_MAX_TIMEOUT	60000 /* milliseconds */
>   

Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Re: [PATCH V1] accel/amdxdna: Switch to always use chained command
Posted by Karol Wachowski 1 day, 3 hours ago
On 2/6/2026 7:02 AM, Lizhi Hou wrote:
> Preempt commands are only supported when submitted as chained commands.
> To ensure preempt support works consistently, always submit commands in
> chained command format.
> 
> Set force_cmdlist to true so that single commands are filled using the
> chained command layout, enabling correct handling of preempt commands.
> 
> Fixes: 3a0ff7b98af4 ("accel/amdxdna: Support preemption requests")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> ---
>  drivers/accel/amdxdna/aie2_ctx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
> index 37d05f2e986f..6378a0bc7b6e 100644
> --- a/drivers/accel/amdxdna/aie2_ctx.c
> +++ b/drivers/accel/amdxdna/aie2_ctx.c
> @@ -23,9 +23,9 @@
>  #include "amdxdna_pci_drv.h"
>  #include "amdxdna_pm.h"
>  
> -static bool force_cmdlist;
> +static bool force_cmdlist = true;
>  module_param(force_cmdlist, bool, 0600);
> -MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default false)");
> +MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default true)");
>  
>  #define HWCTX_MAX_TIMEOUT	60000 /* milliseconds */
>  
Reviewed-by: Karol Wachowski <karol.wachowski@linux.intel.com>