Enable Qualcomm BCL hardware devicetree binding configuration
for pm7250b.
Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/pm7250b.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
index 0761e6b5fd8d..69ad76831cde 100644
--- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
@@ -202,6 +202,16 @@ pm7250b_gpios: gpio@c000 {
interrupt-controller;
#interrupt-cells = <2>;
};
+
+ bcl@1d00 {
+ compatible = "qcom,pm7250b-bcl", "qcom,bcl-v1";
+ reg = <0x1d00>;
+ interrupts = <PM7250B_SID 0x1d 0x0 IRQ_TYPE_EDGE_RISING>,
+ <PM7250B_SID 0x1d 0x1 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "bcl-max-min",
+ "bcl-critical";
+ overcurrent-thresholds-milliamp = <5500 6000>;
+ };
};
pmic@PM7250B_SID1 {
--
2.43.0
On 2/5/26 10:14 PM, Manaf Meethalavalappu Pallikunhi wrote:
> Enable Qualcomm BCL hardware devicetree binding configuration
> for pm7250b.
>
> Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/pm7250b.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> index 0761e6b5fd8d..69ad76831cde 100644
> --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> @@ -202,6 +202,16 @@ pm7250b_gpios: gpio@c000 {
> interrupt-controller;
> #interrupt-cells = <2>;
> };
> +
> + bcl@1d00 {
> + compatible = "qcom,pm7250b-bcl", "qcom,bcl-v1";
> + reg = <0x1d00>;
> + interrupts = <PM7250B_SID 0x1d 0x0 IRQ_TYPE_EDGE_RISING>,
> + <PM7250B_SID 0x1d 0x1 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "bcl-max-min",
> + "bcl-critical";
We should strip the "bcl-" prefix, since these interrupts happen
to be under the bcl device
> + overcurrent-thresholds-milliamp = <5500 6000>;
Is that something that we expect to change between boards, or is
that an electrical characteristic of the PM7250B?
Konrad
On 2/5/26 10:14 PM, Manaf Meethalavalappu Pallikunhi wrote:
> Enable Qualcomm BCL hardware devicetree binding configuration
> for pm7250b.
>
> Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/pm7250b.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> index 0761e6b5fd8d..69ad76831cde 100644
> --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> @@ -202,6 +202,16 @@ pm7250b_gpios: gpio@c000 {
> interrupt-controller;
> #interrupt-cells = <2>;
> };
> +
> + bcl@1d00 {
This should be higher up (the node above is 0xc000, this one is 0x1d00)
Konrad
On Fri, Feb 06, 2026 at 02:44:07AM +0530, Manaf Meethalavalappu Pallikunhi wrote:
> Enable Qualcomm BCL hardware devicetree binding configuration
> for pm7250b.
>
> Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/pm7250b.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> index 0761e6b5fd8d..69ad76831cde 100644
> --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> @@ -202,6 +202,16 @@ pm7250b_gpios: gpio@c000 {
> interrupt-controller;
> #interrupt-cells = <2>;
> };
> +
> + bcl@1d00 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).
Plus, I doubt this was ever tested. Considering lack of internal review
I do not think this should be posted.
Best regards,
Krzysztof
© 2016 - 2026 Red Hat, Inc.