hinic3: select CONFIG_DIMLIB

[PATCH] [net-next] hinic3: select CONFIG_DIMLIB

Posted by Arnd Bergmann 1 day, 19 hours ago

From: Arnd Bergmann <arnd@arndb.de>

The driver started using dimlib but fails to select the corresponding
symbol, which results in a link failure:

x86_64-linux-ld: drivers/net/ethernet/huawei/hinic3/hinic3_irq.o: in function `hinic3_poll':
hinic3_irq.c:(.text+0x179): undefined reference to `net_dim'
x86_64-linux-ld: drivers/net/ethernet/huawei/hinic3/hinic3_irq.o: in function `hinic3_rx_dim_work':
hinic3_irq.c:(.text+0x1fb): undefined reference to `net_dim_get_rx_moderation'

Fixes: b35a6fd37a00 ("hinic3: Add adaptive IRQ coalescing with DIM")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/huawei/hinic3/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/huawei/hinic3/Kconfig b/drivers/net/ethernet/huawei/hinic3/Kconfig
index ce4331d1387b..02d6f91a7f4a 100644
--- a/drivers/net/ethernet/huawei/hinic3/Kconfig
+++ b/drivers/net/ethernet/huawei/hinic3/Kconfig
@@ -11,6 +11,7 @@ config HINIC3
 	depends on X86 || ARM64 || COMPILE_TEST
 	depends on PCI_MSI && 64BIT
 	select AUXILIARY_BUS
+	select DIMLIB
 	select PAGE_POOL
 	help
 	  This driver supports HiNIC 3rd gen Network Adapter (HINIC3).
-- 
2.39.5

Re: [PATCH] [net-next] hinic3: select CONFIG_DIMLIB

Posted by Vadim Fedorenko 22 hours ago

On 05/02/2026 16:13, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver started using dimlib but fails to select the corresponding
> symbol, which results in a link failure:
> 
> x86_64-linux-ld: drivers/net/ethernet/huawei/hinic3/hinic3_irq.o: in function `hinic3_poll':
> hinic3_irq.c:(.text+0x179): undefined reference to `net_dim'
> x86_64-linux-ld: drivers/net/ethernet/huawei/hinic3/hinic3_irq.o: in function `hinic3_rx_dim_work':
> hinic3_irq.c:(.text+0x1fb): undefined reference to `net_dim_get_rx_moderation'
> 
> Fixes: b35a6fd37a00 ("hinic3: Add adaptive IRQ coalescing with DIM")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/net/ethernet/huawei/hinic3/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/huawei/hinic3/Kconfig b/drivers/net/ethernet/huawei/hinic3/Kconfig
> index ce4331d1387b..02d6f91a7f4a 100644
> --- a/drivers/net/ethernet/huawei/hinic3/Kconfig
> +++ b/drivers/net/ethernet/huawei/hinic3/Kconfig
> @@ -11,6 +11,7 @@ config HINIC3
>   	depends on X86 || ARM64 || COMPILE_TEST
>   	depends on PCI_MSI && 64BIT
>   	select AUXILIARY_BUS
> +	select DIMLIB
>   	select PAGE_POOL
>   	help
>   	  This driver supports HiNIC 3rd gen Network Adapter (HINIC3).

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>