staging: rtl8723bs: constify _action_public_str in rtw_ieee80211.c

[PATCH v2] staging: rtl8723bs: constify _action_public_str in rtw_ieee80211.c

Posted by Haroen Tmimi 1 day, 20 hours ago

Make the _action_public_str array "static const char * const".

This ensures the array entries are read-only, preventing accidental
modification of the pointers.

Signed-off-by: Haroen Tmimi <tmimiharoen@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index 92b12a13d27c..febc14de6bc0 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -1139,7 +1139,7 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act
 	return true;
 }
 
-static const char *_action_public_str[] = {
+static const char * const _action_public_str[] = {
 	"ACT_PUB_BSSCOEXIST",
 	"ACT_PUB_DSE_ENABLE",
 	"ACT_PUB_DSE_DEENABLE",
-- 
2.53.0

Re: [PATCH v2] staging: rtl8723bs: constify _action_public_str in rtw_ieee80211.c

Posted by Ethan Tidmore 1 day, 16 hours ago

On Thu Feb 5, 2026 at 6:09 AM CST, Haroen Tmimi wrote:
> Make the _action_public_str array "static const char * const".
>
> This ensures the array entries are read-only, preventing accidental
> modification of the pointers.
>
> Signed-off-by: Haroen Tmimi <tmimiharoen@gmail.com>

Looks good to me.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

ET