1. Patchew
  2. linux
  3. [PATCH v2 0/3] hwmon: pmbus: Add support for MPQ8786
  4. View patch

[PATCH v2 1/3] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support

Carl Lee via B4 Relay posted 3 patches 5 days, 6 hours ago
[PATCH v2 1/3] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support
Posted by Carl Lee via B4 Relay 5 days, 6 hours ago 
From: Carl Lee <carl.lee@amd.com>

Add device type support for MPQ8786

Signed-off-by: Carl Lee <carl.lee@amd.com>
---
 Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
index 90970a0433e9..aec7397a29f9 100644
--- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
@@ -19,6 +19,7 @@ properties:
       - mps,mpm3695-25
       - mps,mpm82504
       - mps,mpq8785
+      - mps,mpq8786
 
   reg:
     maxItems: 1
@@ -52,7 +53,9 @@ allOf:
   - if:
       properties:
         compatible:
-          const: mps,mpq8785
+          enum:
+            - mps,mpq8785
+            - mps,mpq8786
     then:
       properties:
         mps,vout-fb-divider-ratio-permille:

-- 
2.34.1
Re: [PATCH v2 1/3] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support
Posted by Krzysztof Kozlowski 5 days, 2 hours ago 
On Thu, Feb 05, 2026 at 06:01:37PM +0800, Carl Lee wrote:
> Add device type support for MPQ8786
> 
> Signed-off-by: Carl Lee <carl.lee@amd.com>
> ---
>  Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> index 90970a0433e9..aec7397a29f9 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> @@ -19,6 +19,7 @@ properties:
>        - mps,mpm3695-25
>        - mps,mpm82504
>        - mps,mpq8785
> +      - mps,mpq8786

Your driver code says they are the same, so compatible. Express it with
fallback or provide real rationale in commit msg.

Best regards,
Krzysztof
Re: [PATCH v2 1/3] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support
Posted by Guenter Roeck 4 days, 23 hours ago 
On Thu, Feb 05, 2026 at 02:46:29PM +0100, Krzysztof Kozlowski wrote:
> On Thu, Feb 05, 2026 at 06:01:37PM +0800, Carl Lee wrote:
> > Add device type support for MPQ8786
> > 
> > Signed-off-by: Carl Lee <carl.lee@amd.com>
> > ---
> >  Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > index 90970a0433e9..aec7397a29f9 100644
> > --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > @@ -19,6 +19,7 @@ properties:
> >        - mps,mpm3695-25
> >        - mps,mpm82504
> >        - mps,mpq8785
> > +      - mps,mpq8786
> 
> Your driver code says they are the same, so compatible. Express it with
> fallback or provide real rationale in commit msg.
> 

Agreed. The mpq8785 datasheet is public, but the mpq8786 datasheet isn't.
That makes it all but impossible to determine if there are indeed no
notable differences between the chips.

Guenter
Re: [PATCH v2 1/3] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support
Posted by Carl Lee 4 days, 9 hours ago 
On Thu, Feb 05, 2026 at 08:17:07AM -0800, Guenter Roeck wrote:
> On Thu, Feb 05, 2026 at 02:46:29PM +0100, Krzysztof Kozlowski wrote:
> > On Thu, Feb 05, 2026 at 06:01:37PM +0800, Carl Lee wrote:
> > > Add device type support for MPQ8786
> > > 
> > > Signed-off-by: Carl Lee <carl.lee@amd.com>
> > > ---
> > >  Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > index 90970a0433e9..aec7397a29f9 100644
> > > --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > @@ -19,6 +19,7 @@ properties:
> > >        - mps,mpm3695-25
> > >        - mps,mpm82504
> > >        - mps,mpq8785
> > > +      - mps,mpq8786
> > 
> > Your driver code says they are the same, so compatible. Express it with
> > fallback or provide real rationale in commit msg.
> > 
> 
> Agreed. The mpq8785 datasheet is public, but the mpq8786 datasheet isn't.
> That makes it all but impossible to determine if there are indeed no
> notable differences between the chips.
> 
> Guenter

There is no chip-specific difference in the driver code to justify
separate MPQ8786 support. 
Therefore, Therefore, I will use MPQ8785 for support.
Re: [PATCH v2 1/3] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support
Posted by Krzysztof Kozlowski 3 days, 5 hours ago 
On 06/02/2026 07:46, Carl Lee wrote:
> On Thu, Feb 05, 2026 at 08:17:07AM -0800, Guenter Roeck wrote:
>> On Thu, Feb 05, 2026 at 02:46:29PM +0100, Krzysztof Kozlowski wrote:
>>> On Thu, Feb 05, 2026 at 06:01:37PM +0800, Carl Lee wrote:
>>>> Add device type support for MPQ8786
>>>>
>>>> Signed-off-by: Carl Lee <carl.lee@amd.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
>>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
>>>> index 90970a0433e9..aec7397a29f9 100644
>>>> --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
>>>> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
>>>> @@ -19,6 +19,7 @@ properties:
>>>>        - mps,mpm3695-25
>>>>        - mps,mpm82504
>>>>        - mps,mpq8785
>>>> +      - mps,mpq8786
>>>
>>> Your driver code says they are the same, so compatible. Express it with
>>> fallback or provide real rationale in commit msg.
>>>
>>
>> Agreed. The mpq8785 datasheet is public, but the mpq8786 datasheet isn't.
>> That makes it all but impossible to determine if there are indeed no
>> notable differences between the chips.
>>
>> Guenter
> 
> There is no chip-specific difference in the driver code to justify
> separate MPQ8786 support. 
> Therefore, Therefore, I will use MPQ8785 for support.

One message is enough.

Best regards,
Krzysztof
Re: [PATCH v2 1/3] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support
Posted by Carl Lee 4 days, 9 hours ago 
On Thu, Feb 05, 2026 at 08:17:07AM -0800, Guenter Roeck wrote:
> On Thu, Feb 05, 2026 at 02:46:29PM +0100, Krzysztof Kozlowski wrote:
> > On Thu, Feb 05, 2026 at 06:01:37PM +0800, Carl Lee wrote:
> > > Add device type support for MPQ8786
> > > 
> > > Signed-off-by: Carl Lee <carl.lee@amd.com>
> > > ---
> > >  Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > index 90970a0433e9..aec7397a29f9 100644
> > > --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > @@ -19,6 +19,7 @@ properties:
> > >        - mps,mpm3695-25
> > >        - mps,mpm82504
> > >        - mps,mpq8785
> > > +      - mps,mpq8786
> > 
> > Your driver code says they are the same, so compatible. Express it with
> > fallback or provide real rationale in commit msg.
> > 
> 
> Agreed. The mpq8785 datasheet is public, but the mpq8786 datasheet isn't.
> That makes it all but impossible to determine if there are indeed no
> notable differences between the chips.
> 
> Guenter

Agreed. There is no chip-specific difference in the driver code to justify
separate MPQ8786 support. 
Therefore, Therefore, I will use MPQ8785 for support.
Re: [PATCH v2 1/3] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support
Posted by Carl Lee 4 days, 10 hours ago 
On Thu, Feb 05, 2026 at 08:17:07AM -0800, Guenter Roeck wrote:
> On Thu, Feb 05, 2026 at 02:46:29PM +0100, Krzysztof Kozlowski wrote:
> > On Thu, Feb 05, 2026 at 06:01:37PM +0800, Carl Lee wrote:
> > > Add device type support for MPQ8786
> > > 
> > > Signed-off-by: Carl Lee <carl.lee@amd.com>
> > > ---
> > >  Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > index 90970a0433e9..aec7397a29f9 100644
> > > --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> > > @@ -19,6 +19,7 @@ properties:
> > >        - mps,mpm3695-25
> > >        - mps,mpm82504
> > >        - mps,mpq8785
> > > +      - mps,mpq8786
> > 
> > Your driver code says they are the same, so compatible. Express it with
> > fallback or provide real rationale in commit msg.
> > 
> 
> Agreed. The mpq8785 datasheet is public, but the mpq8786 datasheet isn't.
> That makes it all but impossible to determine if there are indeed no
> notable differences between the chips.
> 
> Guenter

Agreed. There is no chip-specific difference in the driver code to justify
separate MPQ8786 support. Therefore, we rely on MPQ8785 support.

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.