[v3] sunrpc: Fix `make W=1` build issues

[PATCH v3 0/3] sunrpc: Fix `make W=1` build issues

Posted by Andy Shevchenko 2 days, 7 hours ago

Compiler is not happy about unused variables (especially when
dprintk() call is defined as no-op). Here is the series to
address the issues.

Changelog v3:
- removed ifdeffery to have struct rpc_task::tk_pid available (LKP)
- collected more tags (Anna, Jeff)

v2: 20260204094500.2443455-1-andriy.shevchenko@linux.intel.com

Changelog v2:
- added patch to kill RPC_IFDEBUG() macro (LKP, Geert)
- united separate patches in the series
- collected tags (Geert)

v1: 20260204010402.2149563-1-andriy.shevchenko@linux.intel.com
v1: 20260204010415.2149607-1-andriy.shevchenko@linux.intel.com

Andy Shevchenko (3):
  nfs/blocklayout: Fix compilation error (`make W=1`) in
    bl_write_pagelist()
  sunrpc: Kill RPC_IFDEBUG()
  sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op

 fs/lockd/svclock.c                       |  5 +++++
 fs/nfs/blocklayout/blocklayout.c         |  4 +---
 fs/nfsd/nfsfh.c                          |  9 +++++---
 include/linux/sunrpc/debug.h             | 10 +++++----
 include/linux/sunrpc/sched.h             |  3 ---
 net/sunrpc/xprtrdma/svc_rdma_transport.c | 27 ++++++++++++------------
 6 files changed, 32 insertions(+), 26 deletions(-)

-- 
2.50.1

Re: [PATCH v3 0/3] sunrpc: Fix `make W=1` build issues

Posted by Chuck Lever 2 days, 5 hours ago

From: Chuck Lever <chuck.lever@oracle.com>

On Wed, 04 Feb 2026 21:21:48 +0100, Andy Shevchenko wrote:
> Compiler is not happy about unused variables (especially when
> dprintk() call is defined as no-op). Here is the series to
> address the issues.
> 
> Changelog v3:
> - removed ifdeffery to have struct rpc_task::tk_pid available (LKP)
> - collected more tags (Anna, Jeff)
> 
> [...]

Applied to nfsd-testing, thanks!

[1/3] nfs/blocklayout: Fix compilation error (`make W=1`) in bl_write_pagelist()
      commit: 5ea3d8c52742bc3fef3b1399ecb6d750fa94b11c
[2/3] sunrpc: Kill RPC_IFDEBUG()
      commit: 69998e1a90d71181df815570a89e972a8bde2b0e
[3/3] sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op
      commit: d5a6213462466a15cecb601896eb4df81aa13b9f

--
Chuck Lever

Re: [PATCH v3 0/3] sunrpc: Fix `make W=1` build issues

Posted by Andy Shevchenko 17 hours ago

On Wed, Feb 04, 2026 at 05:05:35PM -0500, Chuck Lever wrote:

> On Wed, 04 Feb 2026 21:21:48 +0100, Andy Shevchenko wrote:

[...]

> Applied to nfsd-testing, thanks!

Thanks!

FWIW, I have got a success report from LKP.

-- 
With Best Regards,
Andy Shevchenko