[PATCH v2 1/3] nfs/blocklayout: Fix compilation error (`make W=1`) in bl_write_pagelist()

Andy Shevchenko posted 3 patches 3 days ago
There is a newer version of this series
[PATCH v2 1/3] nfs/blocklayout: Fix compilation error (`make W=1`) in bl_write_pagelist()
Posted by Andy Shevchenko 3 days ago
Clang compiler is not happy about set but unused variable
(when dprintk() is no-op):

.../blocklayout/blocklayout.c:384:9: error: variable 'count' set but not used [-Werror,-Wunused-but-set-variable]

Remove a leftover from the previous cleanup.

Fixes: 3a6fd1f004fc ("pnfs/blocklayout: remove read-modify-write handling in bl_write_pagelist")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 fs/nfs/blocklayout/blocklayout.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c
index 0e4c67373e4f..83e4a32b3018 100644
--- a/fs/nfs/blocklayout/blocklayout.c
+++ b/fs/nfs/blocklayout/blocklayout.c
@@ -381,14 +381,13 @@ bl_write_pagelist(struct nfs_pgio_header *header, int sync)
 	sector_t isect, extent_length = 0;
 	struct parallel_io *par = NULL;
 	loff_t offset = header->args.offset;
-	size_t count = header->args.count;
 	struct page **pages = header->args.pages;
 	int pg_index = header->args.pgbase >> PAGE_SHIFT;
 	unsigned int pg_len;
 	struct blk_plug plug;
 	int i;
 
-	dprintk("%s enter, %zu@%lld\n", __func__, count, offset);
+	dprintk("%s enter, %u@%lld\n", __func__, header->args.count, offset);
 
 	/* At this point, header->page_aray is a (sequential) list of nfs_pages.
 	 * We want to write each, and if there is an error set pnfs_error
@@ -429,7 +428,6 @@ bl_write_pagelist(struct nfs_pgio_header *header, int sync)
 		}
 
 		offset += pg_len;
-		count -= pg_len;
 		isect += (pg_len >> SECTOR_SHIFT);
 		extent_length -= (pg_len >> SECTOR_SHIFT);
 	}
-- 
2.50.1
Re: [PATCH v2 1/3] nfs/blocklayout: Fix compilation error (`make W=1`) in bl_write_pagelist()
Posted by Anna Schumaker 2 days, 18 hours ago

On Wed, Feb 4, 2026, at 4:41 AM, Andy Shevchenko wrote:
> Clang compiler is not happy about set but unused variable
> (when dprintk() is no-op):
>
> .../blocklayout/blocklayout.c:384:9: error: variable 'count' set but 
> not used [-Werror,-Wunused-but-set-variable]
>
> Remove a leftover from the previous cleanup.
>
> Fixes: 3a6fd1f004fc ("pnfs/blocklayout: remove read-modify-write 
> handling in bl_write_pagelist")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Anna Schumaker <anna.schumkaer@oracle.com>

> ---
>  fs/nfs/blocklayout/blocklayout.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/nfs/blocklayout/blocklayout.c 
> b/fs/nfs/blocklayout/blocklayout.c
> index 0e4c67373e4f..83e4a32b3018 100644
> --- a/fs/nfs/blocklayout/blocklayout.c
> +++ b/fs/nfs/blocklayout/blocklayout.c
> @@ -381,14 +381,13 @@ bl_write_pagelist(struct nfs_pgio_header *header, 
> int sync)
>  	sector_t isect, extent_length = 0;
>  	struct parallel_io *par = NULL;
>  	loff_t offset = header->args.offset;
> -	size_t count = header->args.count;
>  	struct page **pages = header->args.pages;
>  	int pg_index = header->args.pgbase >> PAGE_SHIFT;
>  	unsigned int pg_len;
>  	struct blk_plug plug;
>  	int i;
> 
> -	dprintk("%s enter, %zu@%lld\n", __func__, count, offset);
> +	dprintk("%s enter, %u@%lld\n", __func__, header->args.count, offset);
> 
>  	/* At this point, header->page_aray is a (sequential) list of nfs_pages.
>  	 * We want to write each, and if there is an error set pnfs_error
> @@ -429,7 +428,6 @@ bl_write_pagelist(struct nfs_pgio_header *header, int sync)
>  		}
> 
>  		offset += pg_len;
> -		count -= pg_len;
>  		isect += (pg_len >> SECTOR_SHIFT);
>  		extent_length -= (pg_len >> SECTOR_SHIFT);
>  	}
> -- 
> 2.50.1
Re: [PATCH v2 1/3] nfs/blocklayout: Fix compilation error (`make W=1`) in bl_write_pagelist()
Posted by Andy Shevchenko 2 days, 17 hours ago
On Wed, Feb 04, 2026 at 10:53:26AM -0500, Anna Schumaker wrote:
> On Wed, Feb 4, 2026, at 4:41 AM, Andy Shevchenko wrote:
> > Clang compiler is not happy about set but unused variable
> > (when dprintk() is no-op):
> >
> > .../blocklayout/blocklayout.c:384:9: error: variable 'count' set but 
> > not used [-Werror,-Wunused-but-set-variable]
> >
> > Remove a leftover from the previous cleanup.
> >
> > Fixes: 3a6fd1f004fc ("pnfs/blocklayout: remove read-modify-write 
> > handling in bl_write_pagelist")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Acked-by: Anna Schumaker <anna.schumkaer@oracle.com>

Thank you!

-- 
With Best Regards,
Andy Shevchenko