fs/lockd/svclock.c | 5 +++++ fs/nfs/blocklayout/blocklayout.c | 4 +--- fs/nfsd/nfsfh.c | 9 +++++--- include/linux/sunrpc/debug.h | 10 +++++---- net/sunrpc/xprtrdma/svc_rdma_transport.c | 27 ++++++++++++------------ 5 files changed, 32 insertions(+), 23 deletions(-)
Compiler is not happy about unused variables (especially when
dprintk() call is defined as no-op). Here is the series to
address the issues.
Changelog v2:
- added patch to kill RPC_IFDEBUG() macro (LKP, Geert)
- united separate patches in the series
- collected tags (Geert)
v1: 20260204010402.2149563-1-andriy.shevchenko@linux.intel.com
v1: 20260204010415.2149607-1-andriy.shevchenko@linux.intel.com
Andy Shevchenko (3):
nfs/blocklayout: Fix compilation error (`make W=1`) in
bl_write_pagelist()
sunrpc: Kill RPC_IFDEBUG()
sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op
fs/lockd/svclock.c | 5 +++++
fs/nfs/blocklayout/blocklayout.c | 4 +---
fs/nfsd/nfsfh.c | 9 +++++---
include/linux/sunrpc/debug.h | 10 +++++----
net/sunrpc/xprtrdma/svc_rdma_transport.c | 27 ++++++++++++------------
5 files changed, 32 insertions(+), 23 deletions(-)
--
2.50.1
From: Chuck Lever <chuck.lever@oracle.com>
On Wed, 04 Feb 2026 10:41:20 +0100, Andy Shevchenko wrote:
> Compiler is not happy about unused variables (especially when
> dprintk() call is defined as no-op). Here is the series to
> address the issues.
>
> Changelog v2:
> - added patch to kill RPC_IFDEBUG() macro (LKP, Geert)
> - united separate patches in the series
> - collected tags (Geert)
>
> [...]
Applied to nfsd-testing, thanks!
Acks from the NFS client maintainers on 1/3 are welcome.
[1/3] nfs/blocklayout: Fix compilation error (`make W=1`) in bl_write_pagelist()
commit: b2e8b11ff47d3ba5075844ac4fb806296b3c4859
[2/3] sunrpc: Kill RPC_IFDEBUG()
commit: 85acbbcb4127f635c062cb52e5dbc62b0635b3f8
[3/3] sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op
commit: 380f84a3c8fc3809b614a6765c2fb0acc3e8674b
--
Chuck Lever
On Wed, Feb 04, 2026 at 10:42:06AM -0500, Chuck Lever wrote: > On Wed, 04 Feb 2026 10:41:20 +0100, Andy Shevchenko wrote: [...] > Applied to nfsd-testing, thanks! > > Acks from the NFS client maintainers on 1/3 are welcome. Thank you! -- With Best Regards, Andy Shevchenko
On Wed, 2026-02-04 at 10:41 +0100, Andy Shevchenko wrote: > Compiler is not happy about unused variables (especially when > dprintk() call is defined as no-op). Here is the series to > address the issues. > > Changelog v2: > - added patch to kill RPC_IFDEBUG() macro (LKP, Geert) > - united separate patches in the series > - collected tags (Geert) > > v1: 20260204010402.2149563-1-andriy.shevchenko@linux.intel.com > v1: 20260204010415.2149607-1-andriy.shevchenko@linux.intel.com > > Andy Shevchenko (3): > nfs/blocklayout: Fix compilation error (`make W=1`) in > bl_write_pagelist() > sunrpc: Kill RPC_IFDEBUG() > sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op > > fs/lockd/svclock.c | 5 +++++ > fs/nfs/blocklayout/blocklayout.c | 4 +--- > fs/nfsd/nfsfh.c | 9 +++++--- > include/linux/sunrpc/debug.h | 10 +++++---- > net/sunrpc/xprtrdma/svc_rdma_transport.c | 27 ++++++++++++------------ > 5 files changed, 32 insertions(+), 23 deletions(-) These all look like good changes to me. The first patch should go to Trond/Anna and Chuck will probably pick up the other two? Reviewed-by: Jeff Layton <jlayton@kernel.org>
On Wed, Feb 04, 2026 at 09:28:28AM -0500, Jeff Layton wrote: > On Wed, 2026-02-04 at 10:41 +0100, Andy Shevchenko wrote: > > Compiler is not happy about unused variables (especially when > > dprintk() call is defined as no-op). Here is the series to > > address the issues. > > > > Changelog v2: > > - added patch to kill RPC_IFDEBUG() macro (LKP, Geert) > > - united separate patches in the series > > - collected tags (Geert) > > > > v1: 20260204010402.2149563-1-andriy.shevchenko@linux.intel.com > > v1: 20260204010415.2149607-1-andriy.shevchenko@linux.intel.com > > > > Andy Shevchenko (3): > > nfs/blocklayout: Fix compilation error (`make W=1`) in > > bl_write_pagelist() > > sunrpc: Kill RPC_IFDEBUG() > > sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op > > > > fs/lockd/svclock.c | 5 +++++ > > fs/nfs/blocklayout/blocklayout.c | 4 +--- > > fs/nfsd/nfsfh.c | 9 +++++--- > > include/linux/sunrpc/debug.h | 10 +++++---- > > net/sunrpc/xprtrdma/svc_rdma_transport.c | 27 ++++++++++++------------ > > 5 files changed, 32 insertions(+), 23 deletions(-) > > These all look like good changes to me. The first patch should go to > Trond/Anna and Chuck will probably pick up the other two? As I explained in v1, the error in the first patch may be shadowed if the third one (and hence second) is taken first. That's why I prefer them to go via single place. > Reviewed-by: Jeff Layton <jlayton@kernel.org> Thanks! -- With Best Regards, Andy Shevchenko
On 2/4/26 9:28 AM, Jeff Layton wrote: > On Wed, 2026-02-04 at 10:41 +0100, Andy Shevchenko wrote: >> Compiler is not happy about unused variables (especially when >> dprintk() call is defined as no-op). Here is the series to >> address the issues. >> >> Changelog v2: >> - added patch to kill RPC_IFDEBUG() macro (LKP, Geert) >> - united separate patches in the series >> - collected tags (Geert) >> >> v1: 20260204010402.2149563-1-andriy.shevchenko@linux.intel.com >> v1: 20260204010415.2149607-1-andriy.shevchenko@linux.intel.com >> >> Andy Shevchenko (3): >> nfs/blocklayout: Fix compilation error (`make W=1`) in >> bl_write_pagelist() >> sunrpc: Kill RPC_IFDEBUG() >> sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op >> >> fs/lockd/svclock.c | 5 +++++ >> fs/nfs/blocklayout/blocklayout.c | 4 +--- >> fs/nfsd/nfsfh.c | 9 +++++--- >> include/linux/sunrpc/debug.h | 10 +++++---- >> net/sunrpc/xprtrdma/svc_rdma_transport.c | 27 ++++++++++++------------ >> 5 files changed, 32 insertions(+), 23 deletions(-) > > These all look like good changes to me. The first patch should go to > Trond/Anna and Chuck will probably pick up the other two? That's what I was thinking, as long as there aren't any dependencies between 1/3 and the others. > Reviewed-by: Jeff Layton <jlayton@kernel.org> -- Chuck Lever
On Wed, Feb 04, 2026 at 09:30:30AM -0500, Chuck Lever wrote: > On 2/4/26 9:28 AM, Jeff Layton wrote: > > On Wed, 2026-02-04 at 10:41 +0100, Andy Shevchenko wrote: ... > >> Andy Shevchenko (3): > >> nfs/blocklayout: Fix compilation error (`make W=1`) in > >> bl_write_pagelist() > >> sunrpc: Kill RPC_IFDEBUG() > >> sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op > > These all look like good changes to me. The first patch should go to > > Trond/Anna and Chuck will probably pick up the other two? > That's what I was thinking, as long as there aren't any dependencies > between 1/3 and the others. There are no explicit compilation dependencies, but if one will wonder in the future the third patch alone may "fix" the first issue. That's why I prefer them going together. -- With Best Regards, Andy Shevchenko
On Wed, Feb 04, 2026 at 10:41:20AM +0100, Andy Shevchenko wrote: > Compiler is not happy about unused variables (especially when > dprintk() call is defined as no-op). Here is the series to > address the issues. Note, I assumed that this goes via NFS tree, but if net wants to take it, I will be glad as well! -- With Best Regards, Andy Shevchenko
© 2016 - 2026 Red Hat, Inc.