[v1] s390: remove kvm_types.h from Kbuild

[PATCH] s390: remove kvm_types.h from Kbuild

Posted by Randy Dunlap 3 days, 23 hours ago

kvm_types.h is mandatory in include/asm-generic/Kbuild so having it
in another Kbuild file causes a warning. Remove it from the arch/
Kbuild file to fix the warning.

../scripts/Makefile.asm-headers:39: redundant generic-y found in ../arch/s390/include/asm/Kbuild: kvm_types.h

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: linux-s390@vger.kernel.org

 arch/s390/include/asm/Kbuild |    1 -
 1 file changed, 1 deletion(-)

--- linux-next-20260202.orig/arch/s390/include/asm/Kbuild
+++ linux-next-20260202/arch/s390/include/asm/Kbuild
@@ -5,6 +5,5 @@ generated-y += syscall_table.h
 generated-y += unistd_nr.h
 
 generic-y += asm-offsets.h
-generic-y += kvm_types.h
 generic-y += mcs_spinlock.h
 generic-y += mmzone.h

Re: [PATCH] s390: remove kvm_types.h from Kbuild

Posted by Heiko Carstens 2 days, 10 hours ago

On Tue, Feb 03, 2026 at 10:42:04AM -0800, Randy Dunlap wrote:
> kvm_types.h is mandatory in include/asm-generic/Kbuild so having it
> in another Kbuild file causes a warning. Remove it from the arch/
> Kbuild file to fix the warning.
> 
> ../scripts/Makefile.asm-headers:39: redundant generic-y found in ../arch/s390/include/asm/Kbuild: kvm_types.h
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
>  arch/s390/include/asm/Kbuild |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- linux-next-20260202.orig/arch/s390/include/asm/Kbuild
> +++ linux-next-20260202/arch/s390/include/asm/Kbuild
> @@ -5,6 +5,5 @@ generated-y += syscall_table.h
>  generated-y += unistd_nr.h
>  
>  generic-y += asm-offsets.h
> -generic-y += kvm_types.h
>  generic-y += mcs_spinlock.h
>  generic-y += mmzone.h

This should go via perf/core from the tip tree, since Peter's not-yet upstream
commit 01122b89361e ("perf: Use EXPORT_SYMBOL_FOR_KVM() for the mediated
APIs") adds the mandatory-y statement to include/asm-generic/Kbuild.

Peter?

Re: [PATCH] s390: remove kvm_types.h from Kbuild

Posted by Peter Zijlstra 2 days, 9 hours ago

On Thu, Feb 05, 2026 at 08:46:43AM +0100, Heiko Carstens wrote:
> On Tue, Feb 03, 2026 at 10:42:04AM -0800, Randy Dunlap wrote:
> > kvm_types.h is mandatory in include/asm-generic/Kbuild so having it
> > in another Kbuild file causes a warning. Remove it from the arch/
> > Kbuild file to fix the warning.
> > 
> > ../scripts/Makefile.asm-headers:39: redundant generic-y found in ../arch/s390/include/asm/Kbuild: kvm_types.h
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > ---
> >  arch/s390/include/asm/Kbuild |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > --- linux-next-20260202.orig/arch/s390/include/asm/Kbuild
> > +++ linux-next-20260202/arch/s390/include/asm/Kbuild
> > @@ -5,6 +5,5 @@ generated-y += syscall_table.h
> >  generated-y += unistd_nr.h
> >  
> >  generic-y += asm-offsets.h
> > -generic-y += kvm_types.h
> >  generic-y += mcs_spinlock.h
> >  generic-y += mmzone.h
> 
> This should go via perf/core from the tip tree, since Peter's not-yet upstream
> commit 01122b89361e ("perf: Use EXPORT_SYMBOL_FOR_KVM() for the mediated
> APIs") adds the mandatory-y statement to include/asm-generic/Kbuild.
> 
> Peter?

Let me see if I can manage to apply a patch I don't have ;-)

[tip: perf/core] s390: remove kvm_types.h from Kbuild

Posted by tip-bot2 for Randy Dunlap 2 days, 8 hours ago

The following commit has been merged into the perf/core branch of tip:

Commit-ID:     7db06e329af30dcb170a6782c1714217ad65033d
Gitweb:        https://git.kernel.org/tip/7db06e329af30dcb170a6782c1714217ad65033d
Author:        Randy Dunlap <rdunlap@infradead.org>
AuthorDate:    Tue, 03 Feb 2026 10:42:04 -08:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Thu, 05 Feb 2026 09:43:47 +01:00

s390: remove kvm_types.h from Kbuild

kvm_types.h is mandatory in include/asm-generic/Kbuild so having it
in another Kbuild file causes a warning. Remove it from the arch/
Kbuild file to fix the warning.

../scripts/Makefile.asm-headers:39: redundant generic-y found in ../arch/s390/include/asm/Kbuild: kvm_types.h

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://patch.msgid.link/20260203184204.1329414-1-rdunlap@infradead.org
---
 arch/s390/include/asm/Kbuild | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/s390/include/asm/Kbuild b/arch/s390/include/asm/Kbuild
index 297bf71..80bad7d 100644
--- a/arch/s390/include/asm/Kbuild
+++ b/arch/s390/include/asm/Kbuild
@@ -5,6 +5,5 @@ generated-y += syscall_table.h
 generated-y += unistd_nr.h
 
 generic-y += asm-offsets.h
-generic-y += kvm_types.h
 generic-y += mcs_spinlock.h
 generic-y += mmzone.h