This patchset cleans up the do_suspend_lowlevel() function, removing
some leftover bits that are no longer necessary since it started
using the SMP trampoline to resune the kernel.

v2:
- Reworked the first patch
- Added more cleanups

Brian Gerst (4):
  x86/acpi/suspend: Remove indirect jump
  x86/acpi/suspend: Remove segment reloads on resume
  x86/acpi/suspend: Clean up stack usage
  x86/acpi/suspend: Remove redundant register saves

 arch/x86/kernel/acpi/sleep.c     | 20 -------------
 arch/x86/kernel/acpi/wakeup_64.S | 50 +++++---------------------------
 2 files changed, 8 insertions(+), 62 deletions(-)


base-commit: faee66660b703935da23b7ae2f955f91472d6487
-- 
2.52.0

On Tue, 3 Feb 2026, at 18:58, Brian Gerst wrote:
> This patchset cleans up the do_suspend_lowlevel() function, removing
> some leftover bits that are no longer necessary since it started
> using the SMP trampoline to resune the kernel.
>
> v2:
> - Reworked the first patch
> - Added more cleanups
>
> Brian Gerst (4):
>   x86/acpi/suspend: Remove indirect jump
>   x86/acpi/suspend: Remove segment reloads on resume
>   x86/acpi/suspend: Clean up stack usage
>   x86/acpi/suspend: Remove redundant register saves
>

This all looks correct to me - the stack changes in patch #3 do result in the stack misalignment to be different than it was before, but it is still 8 byte aligned throughout, which is all we care about in the kernel IIRC?

So

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Tested-by: Ard Biesheuvel <ardb@kernel.org> # qemu SMP suspend/resume

On Tue, Feb 3, 2026 at 6:59 PM Brian Gerst <brgerst@gmail.com> wrote:
>
> This patchset cleans up the do_suspend_lowlevel() function, removing
> some leftover bits that are no longer necessary since it started
> using the SMP trampoline to resune the kernel.
>
> v2:
> - Reworked the first patch
> - Added more cleanups
>
> Brian Gerst (4):
>   x86/acpi/suspend: Remove indirect jump
>   x86/acpi/suspend: Remove segment reloads on resume
>   x86/acpi/suspend: Clean up stack usage
>   x86/acpi/suspend: Remove redundant register saves
>
>  arch/x86/kernel/acpi/sleep.c     | 20 -------------
>  arch/x86/kernel/acpi/wakeup_64.S | 50 +++++---------------------------
>  2 files changed, 8 insertions(+), 62 deletions(-)

Maybe CC linux-acpi@vger.kernel.org.

It would be easier to review somewhat.