driver core: disable revocable code from build

[PATCH] driver core: disable revocable code from build

Posted by Greg Kroah-Hartman 4 days, 2 hours ago

The revocable code is still under active discussion, and there is no
in-kernel users of it.  So disable it from the build for now so that no
one suffers from it being present in the tree, yet leave it in the
source tree so that others can easily test it by reverting this commit
and building off of it for future releases.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/base/Kconfig  | 2 +-
 drivers/base/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index 8f7d7b9d81ac..9f318b98144d 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -254,7 +254,7 @@ endmenu
 # Kunit test cases
 config REVOCABLE_KUNIT_TEST
 	tristate "Kunit tests for revocable" if !KUNIT_ALL_TESTS
-	depends on KUNIT
+	depends on KUNIT && BROKEN
 	default KUNIT_ALL_TESTS
 	help
 	  Kunit tests for the revocable API.
diff --git a/drivers/base/Makefile b/drivers/base/Makefile
index 4185aaa9bbb9..4c6607616a73 100644
--- a/drivers/base/Makefile
+++ b/drivers/base/Makefile
@@ -6,7 +6,7 @@ obj-y			:= component.o core.o bus.o dd.o syscore.o \
 			   cpu.o firmware.o init.o map.o devres.o \
 			   attribute_container.o transport_class.o \
 			   topology.o container.o property.o cacheinfo.o \
-			   swnode.o faux.o revocable.o
+			   swnode.o faux.o
 obj-$(CONFIG_AUXILIARY_BUS) += auxiliary.o
 obj-$(CONFIG_DEVTMPFS)	+= devtmpfs.o
 obj-y			+= power/
-- 
2.53.0

Re: [PATCH] driver core: disable revocable code from build

Posted by Tzung-Bi Shih 3 days, 13 hours ago

On Tue, Feb 03, 2026 at 01:30:37PM +0100, Greg Kroah-Hartman wrote:
> The revocable code is still under active discussion, and there is no
> in-kernel users of it.  So disable it from the build for now so that no
> one suffers from it being present in the tree, yet leave it in the
> source tree so that others can easily test it by reverting this commit
> and building off of it for future releases.
> 
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

And also:

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 11b6515ce3d0..56e44a98d6a5 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -17,7 +17,6 @@ TARGETS += damon
 TARGETS += devices/error_logs
 TARGETS += devices/probe
 TARGETS += dmabuf-heaps
-TARGETS += drivers/base/revocable
 TARGETS += drivers/dma-buf
 TARGETS += drivers/ntsync
 TARGETS += drivers/s390x/uvdevice

With that,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>

[PATCH] selftests: Disable revocable code from build

Posted by Tzung-Bi Shih 3 days, 10 hours ago

The revocable code is still under active discussion, and there is no
in-kernel users of it.  So disable it from the build for now so that no
one suffers from it being present in the tree, yet leave it in the
source tree so that others can easily test it by reverting this commit
and building off of it for future releases.

Fixes: dd7762c73b1c ("driver core: disable revocable code from build")
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
Greg: I realized "driver core: disable revocable code from build" is
already in driver-core-testing branch.  Sent this independent patch
in case it'd need to.

 tools/testing/selftests/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 11b6515ce3d0..56e44a98d6a5 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -17,7 +17,6 @@ TARGETS += damon
 TARGETS += devices/error_logs
 TARGETS += devices/probe
 TARGETS += dmabuf-heaps
-TARGETS += drivers/base/revocable
 TARGETS += drivers/dma-buf
 TARGETS += drivers/ntsync
 TARGETS += drivers/s390x/uvdevice
-- 
2.53.0.rc2.204.g2597b5adb4-goog

Re: [PATCH] selftests: Disable revocable code from build

Posted by Greg Kroah-Hartman 3 days, 7 hours ago

On Wed, Feb 04, 2026 at 05:28:18AM +0000, Tzung-Bi Shih wrote:
> The revocable code is still under active discussion, and there is no
> in-kernel users of it.  So disable it from the build for now so that no
> one suffers from it being present in the tree, yet leave it in the
> source tree so that others can easily test it by reverting this commit
> and building off of it for future releases.
> 
> Fixes: dd7762c73b1c ("driver core: disable revocable code from build")
> Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
> ---
> Greg: I realized "driver core: disable revocable code from build" is
> already in driver-core-testing branch.  Sent this independent patch
> in case it'd need to.
> 
>  tools/testing/selftests/Makefile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 11b6515ce3d0..56e44a98d6a5 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -17,7 +17,6 @@ TARGETS += damon
>  TARGETS += devices/error_logs
>  TARGETS += devices/probe
>  TARGETS += dmabuf-heaps
> -TARGETS += drivers/base/revocable
>  TARGETS += drivers/dma-buf
>  TARGETS += drivers/ntsync
>  TARGETS += drivers/s390x/uvdevice
> -- 
> 2.53.0.rc2.204.g2597b5adb4-goog

Thanks, I'll merge this into the other commit so that it all happens at
once, and can be reverted easier.

greg k-h

Re: [PATCH] driver core: disable revocable code from build

Posted by Danilo Krummrich 4 days, 2 hours ago

On Tue Feb 3, 2026 at 1:30 PM CET, Greg Kroah-Hartman wrote:
> The revocable code is still under active discussion, and there is no
> in-kernel users of it.  So disable it from the build for now so that no
> one suffers from it being present in the tree, yet leave it in the
> source tree so that others can easily test it by reverting this commit
> and building off of it for future releases.
>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Acked-by: Danilo Krummrich <dakr@kernel.org>