[PATCH v6 0/2] staging: axis-fifo: refactor and cleanup

Gustavo Piaz da Silva posted 2 patches 4 days, 18 hours ago
drivers/staging/axis-fifo/axis-fifo.c | 82 +++++++++------------------
1 file changed, 28 insertions(+), 54 deletions(-)
[PATCH v6 0/2] staging: axis-fifo: refactor and cleanup
Posted by Gustavo Piaz da Silva 4 days, 18 hours ago
This series cleans up the axis-fifo driver probe function logic.

Patch 1 aligns the struct types with the OF API.
Patch 2 refactors the parsing logic to be simpler and less verbose.

Changes in v6:
 - Removed the helper function axis_fifo_get_u32() entirely.
 - Kept 'node' local variable in parse_dt to avoid checkpatch line length warnings.
 - Removed dev_err() calls in parse_dt as requested by Greg KH.
 - Fixed checkpatch style warning (missing blank line after declarations).
 - Ensured newline at the end of the file.

Changes in v5:
 - Added missing newline at the end of axis-fifo.c file in Patch 2.

Changes in v4:
 - Removed extra blank lines in commit messages.
 - Added "rx" and "tx" prefixes to error messages in Patch 2 (now removed in v6).
 - Explicitly listed changes in individual patches.

Changes in v3:
 - Split into two patches as requested.

Gustavo Piaz da Silva (2):
  staging: axis-fifo: align fifo depth types with OF API
  staging: axis-fifo: refactor device tree parsing

 drivers/staging/axis-fifo/axis-fifo.c | 82 +++++++++------------------
 1 file changed, 28 insertions(+), 54 deletions(-)

-- 
2.52.0
Re: [PATCH v6 0/2] staging: axis-fifo: refactor and cleanup
Posted by Greg KH 4 days ago
On Mon, Feb 02, 2026 at 11:20:45AM -0300, Gustavo Piaz da Silva wrote:
> This series cleans up the axis-fifo driver probe function logic.
> 
> Patch 1 aligns the struct types with the OF API.
> Patch 2 refactors the parsing logic to be simpler and less verbose.

Please slow down.  One patch series every few days at the most,
otherwise you are not allowing yourself to actually get review comments
from people, and you just move your changes further down the queue.

There's no rush here, relax, take a few days off, and think about what
you are wanting to do here before sending a new version.

thanks,

greg k-h