[PATCH v2] staging: rtl8723bs: make _action_public_str const

Giorgi Tchankvetadze posted 1 patch 4 days, 16 hours ago
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] staging: rtl8723bs: make _action_public_str const
Posted by Giorgi Tchankvetadze 4 days, 16 hours ago
The _action_public_str array is never modified at runtime and 
serves as a lookup table. Mark it 'static const char * const' 
to allow the compiler to put it in the read-only data section.

This fixes a checkpatch warning:
WARNING: static const char * array should probably be static const char * const

Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
v2: add blank line before Signed-off-by (suggested by Dan Carpenter)

 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index 8fdeeda88a6d..4de0875904eb 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -1139,7 +1139,7 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act
 	return true;
 }
 
-static const char *_action_public_str[] = {
+static const char * const _action_public_str[] = {
 	"ACT_PUB_BSSCOEXIST",
 	"ACT_PUB_DSE_ENABLE",
 	"ACT_PUB_DSE_DEENABLE",
-- 
2.52.0
Re: [PATCH v2] staging: rtl8723bs: make _action_public_str const
Posted by Dan Carpenter 4 days, 15 hours ago
On Mon, Feb 02, 2026 at 05:16:50PM +0400, Giorgi Tchankvetadze wrote:
> The _action_public_str array is never modified at runtime and 
> serves as a lookup table. Mark it 'static const char * const' 
> to allow the compiler to put it in the read-only data section.
> 
> This fixes a checkpatch warning:
> WARNING: static const char * array should probably be static const char * const
> 
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
> ---
> v2: add blank line before Signed-off-by (suggested by Dan Carpenter)

Thanks.

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter