pinctrl: polarfire: restore GENERIC_PINCONF dependency

[PATCH] pinctrl: polarfire: restore GENERIC_PINCONF dependency

Posted by Arnd Bergmann 5 days, 2 hours ago

From: Arnd Bergmann <arnd@arndb.de>

Changing over to the new CONFIG_GENERIC_PINCTRL dropped the GENERIC_PINCONF
option, causing a build failure:

WARNING: unmet direct dependencies detected for GENERIC_PINCTRL
  Depends on [n]: PINCTRL [=y] && GENERIC_PINCONF [=y] && GENERIC_PINCTRL_GROUPS [=n] && GENERIC_PINMUX_FUNCTIONS [=n]
  Selected by [y]:
  - PINCTRL_POLARFIRE_SOC [=y] && PINCTRL [=y] && (ARCH_MICROCHIP [=y] || COMPILE_TEST [=y]) && OF [=y]
drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c:296:29: error: 'pinctrl_generic_get_group_count' undeclared here (not in a function)
  296 |         .get_groups_count = pinctrl_generic_get_group_count,
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Select both GENERIC_PINCTRL and GENERIC_PINCONF to address this.

Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pinctrl/microchip/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/pinctrl/microchip/Kconfig b/drivers/pinctrl/microchip/Kconfig
index e8bc01946324..a4ae57725fdb 100644
--- a/drivers/pinctrl/microchip/Kconfig
+++ b/drivers/pinctrl/microchip/Kconfig
@@ -12,6 +12,9 @@ config PINCTRL_POLARFIRE_SOC
 	bool "Polarfire SoC pinctrl drivers"
 	depends on ARCH_MICROCHIP || COMPILE_TEST
 	depends on OF
+	select GENERIC_PINCONF
 	select GENERIC_PINCTRL
+	select GENERIC_PINCTRL_GROUPS
+	select GENERIC_PINMUX_FUNCTIONS
 	help
 	  This selects the pinctrl drivers for Microchip Polarfire SoC.
-- 
2.39.5

Re: [PATCH] pinctrl: polarfire: restore GENERIC_PINCONF dependency

Posted by Conor Dooley 4 days, 16 hours ago

On Mon, Feb 02, 2026 at 10:58:03AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Changing over to the new CONFIG_GENERIC_PINCTRL dropped the GENERIC_PINCONF
> option, causing a build failure:
> 
> WARNING: unmet direct dependencies detected for GENERIC_PINCTRL
>   Depends on [n]: PINCTRL [=y] && GENERIC_PINCONF [=y] && GENERIC_PINCTRL_GROUPS [=n] && GENERIC_PINMUX_FUNCTIONS [=n]
>   Selected by [y]:
>   - PINCTRL_POLARFIRE_SOC [=y] && PINCTRL [=y] && (ARCH_MICROCHIP [=y] || COMPILE_TEST [=y]) && OF [=y]
> drivers/pinctrl/microchip/pinctrl-mpfs-mssio.c:296:29: error: 'pinctrl_generic_get_group_count' undeclared here (not in a function)
>   296 |         .get_groups_count = pinctrl_generic_get_group_count,
>       |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Select both GENERIC_PINCTRL and GENERIC_PINCONF to address this.
> 
> Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Does this show up with
https://lore.kernel.org/all/20260130-stoop-gleeful-29f2c525bd48@spud/
applied?
I considered what you have here, went with what I linked cos it matches
the other pinctrl core options.

> ---
>  drivers/pinctrl/microchip/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pinctrl/microchip/Kconfig b/drivers/pinctrl/microchip/Kconfig
> index e8bc01946324..a4ae57725fdb 100644
> --- a/drivers/pinctrl/microchip/Kconfig
> +++ b/drivers/pinctrl/microchip/Kconfig
> @@ -12,6 +12,9 @@ config PINCTRL_POLARFIRE_SOC
>  	bool "Polarfire SoC pinctrl drivers"
>  	depends on ARCH_MICROCHIP || COMPILE_TEST
>  	depends on OF
> +	select GENERIC_PINCONF
>  	select GENERIC_PINCTRL
> +	select GENERIC_PINCTRL_GROUPS
> +	select GENERIC_PINMUX_FUNCTIONS
>  	help
>  	  This selects the pinctrl drivers for Microchip Polarfire SoC.
> -- 
> 2.39.5
>

Re: [PATCH] pinctrl: polarfire: restore GENERIC_PINCONF dependency

Posted by Linus Walleij 4 days, 12 hours ago

On Mon, Feb 2, 2026 at 8:53 PM Conor Dooley <conor@kernel.org> wrote:

> Does this show up with
> https://lore.kernel.org/all/20260130-stoop-gleeful-29f2c525bd48@spud/
> applied?
> I considered what you have here, went with what I linked cos it matches
> the other pinctrl core options.

I've applied this one now.

Yours,
Linus Walleij

Re: [PATCH] pinctrl: polarfire: restore GENERIC_PINCONF dependency

Posted by Arnd Bergmann 4 days, 16 hours ago

On Mon, Feb 2, 2026, at 20:53, Conor Dooley wrote:
> On Mon, Feb 02, 2026 at 10:58:03AM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>> 
>> Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Does this show up with
> https://lore.kernel.org/all/20260130-stoop-gleeful-29f2c525bd48@spud/
> applied?

I'm sure that's fine as well.

> I considered what you have here, went with what I linked cos it matches
> the other pinctrl core options.

Same here, I also thought about both options, but picked the other one ;-)

Looking at both again, I agree that your version is better, so
feel free to add

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

to that one.

       Arnd