[PATCH v1 1/5] staging: rtl8723bs: remove unused code for other Realtek chips

Luka Gejak posted 5 patches 5 days, 16 hours ago
[PATCH v1 1/5] staging: rtl8723bs: remove unused code for other Realtek chips
Posted by Luka Gejak 5 days, 16 hours ago
Remove unused definitions and function declarations that were left over
from other Realtek chips:

- Remove rtl8192c_translate_rx_signal_stuff() and
  rtl8192c_query_rx_desc_status() function declarations from
  rtl8192c_recv.h. These functions are declared but never implemented
  or used in the 8723bs driver.

- Remove unused RECV_BLK_SZ, RECV_BLK_CNT, and RECV_BLK_TH defines from
  rtl8192c_recv.h. These are not referenced anywhere in the driver.

- Remove unused MAX_PATH_NUM_* definitions for other chips (92CS, 8188E,
  8192E, 8812A, 8821A, 8814A, 8822B) from odm.h. Only MAX_PATH_NUM_8723B
  is actually used by the driver.

This addresses the first TODO item: find and remove any code for other
chips that is left over.

Signed-off-by: Luka Gejak <lukagejak5@gmail.com>
---
 drivers/staging/rtl8723bs/hal/odm.h               | 7 -------
 drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 8 --------
 2 files changed, 15 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
index 1c929d88e596..38830552d5bc 100644
--- a/drivers/staging/rtl8723bs/hal/odm.h
+++ b/drivers/staging/rtl8723bs/hal/odm.h
@@ -202,14 +202,7 @@ struct odm_rate_adaptive {
 /*  */
 /*  Declare for common info */
 /*  */
-#define MAX_PATH_NUM_92CS		2
-#define MAX_PATH_NUM_8188E		1
-#define MAX_PATH_NUM_8192E		2
 #define MAX_PATH_NUM_8723B		1
-#define MAX_PATH_NUM_8812A		2
-#define MAX_PATH_NUM_8821A		1
-#define MAX_PATH_NUM_8814A		4
-#define MAX_PATH_NUM_8822B		2
 
 #define IQK_THRESHOLD			8
 #define DPK_THRESHOLD			4
diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
index 9664758e21be..b63625ab4e45 100644
--- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
+++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
@@ -7,10 +7,6 @@
 #ifndef _RTL8192C_RECV_H_
 #define _RTL8192C_RECV_H_
 
-#define RECV_BLK_SZ 512
-#define RECV_BLK_CNT 16
-#define RECV_BLK_TH RECV_BLK_CNT
-
 #define MAX_RECVBUF_SZ (10240)
 
 struct phy_stat {
@@ -34,8 +30,4 @@ struct phy_stat {
 /*  Rx smooth factor */
 #define	Rx_Smooth_Factor (20)
 
-
-void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe, struct phy_stat *pphy_status);
-void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
-
 #endif
-- 
2.52.0
Re: [PATCH v1 1/5] staging: rtl8723bs: remove unused code for other Realtek chips
Posted by Greg Kroah-Hartman 5 days, 14 hours ago
On Mon, Feb 02, 2026 at 08:07:48AM +0100, Luka Gejak wrote:
> Remove unused definitions and function declarations that were left over
> from other Realtek chips:
> 
> - Remove rtl8192c_translate_rx_signal_stuff() and
>   rtl8192c_query_rx_desc_status() function declarations from
>   rtl8192c_recv.h. These functions are declared but never implemented
>   or used in the 8723bs driver.
> 
> - Remove unused RECV_BLK_SZ, RECV_BLK_CNT, and RECV_BLK_TH defines from
>   rtl8192c_recv.h. These are not referenced anywhere in the driver.
> 
> - Remove unused MAX_PATH_NUM_* definitions for other chips (92CS, 8188E,
>   8192E, 8812A, 8821A, 8814A, 8822B) from odm.h. Only MAX_PATH_NUM_8723B
>   is actually used by the driver.

When you have to list the different things a patch does, that's a huge
hint that the change needs to be broken up into smaller patches.

Remember, each change can only do "one logical thing".

thanks,

greg k-h