[PATCH 08/10] ARM: dts: imx7ulp: remove #clock-cells from clock-controller@40410000

Frank Li posted 10 patches 1 week ago
[PATCH 08/10] ARM: dts: imx7ulp: remove #clock-cells from clock-controller@40410000
Posted by Frank Li 1 week ago
According to the fsl,imx7ulp-pm.yaml binding, clock-controller@40410000 is
not a clock provider. Remove the #clock-cells property to fix the following
CHECK_DTBS warning:
  clock-controller@40410000 (fsl,imx7ulp-smc1): '#clock-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
index 880b9a4f32b0846a773dbf9ad30715c84ac2fda6..6d8853d36d930aabb98fb57f49d6153ca6597561 100644
--- a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
@@ -291,7 +291,6 @@ pcc2: clock-controller@403f0000 {
 		smc1: clock-controller@40410000 {
 			compatible = "fsl,imx7ulp-smc1";
 			reg = <0x40410000 0x1000>;
-			#clock-cells = <1>;
 			clocks = <&scg1 IMX7ULP_CLK_CORE_DIV>,
 				 <&scg1 IMX7ULP_CLK_HSRUN_CORE_DIV>;
 			clock-names = "divcore", "hsrun_divcore";

-- 
2.34.1
Re: [PATCH 08/10] ARM: dts: imx7ulp: remove #clock-cells from clock-controller@40410000
Posted by Peng Fan 6 days, 22 hours ago
On Mon, Feb 02, 2026 at 02:43:25PM -0500, Frank Li wrote:
>According to the fsl,imx7ulp-pm.yaml binding, clock-controller@40410000 is
>not a clock provider. Remove the #clock-cells property to fix the following
>CHECK_DTBS warning:
>  clock-controller@40410000 (fsl,imx7ulp-smc1): '#clock-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
>
>Signed-off-by: Frank Li <Frank.Li@nxp.com>
>---
> arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
>index 880b9a4f32b0846a773dbf9ad30715c84ac2fda6..6d8853d36d930aabb98fb57f49d6153ca6597561 100644
>--- a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
>+++ b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
>@@ -291,7 +291,6 @@ pcc2: clock-controller@403f0000 {
> 		smc1: clock-controller@40410000 {
> 			compatible = "fsl,imx7ulp-smc1";
> 			reg = <0x40410000 0x1000>;
>-			#clock-cells = <1>;

Need to fix binding, this is a clock controller and needs #clock-cells to work
properly.

There is a driver for this compatible:
drivers/clk/imx/clk-imx7ulp.c

Regards,
Peng

> 			clocks = <&scg1 IMX7ULP_CLK_CORE_DIV>,
> 				 <&scg1 IMX7ULP_CLK_HSRUN_CORE_DIV>;
> 			clock-names = "divcore", "hsrun_divcore";
>
>-- 
>2.34.1
>
Re: [PATCH 08/10] ARM: dts: imx7ulp: remove #clock-cells from clock-controller@40410000
Posted by Frank Li 6 days, 8 hours ago
On Tue, Feb 03, 2026 at 09:52:39AM +0800, Peng Fan wrote:
> On Mon, Feb 02, 2026 at 02:43:25PM -0500, Frank Li wrote:
> >According to the fsl,imx7ulp-pm.yaml binding, clock-controller@40410000 is
> >not a clock provider. Remove the #clock-cells property to fix the following
> >CHECK_DTBS warning:
> >  clock-controller@40410000 (fsl,imx7ulp-smc1): '#clock-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
> >
> >Signed-off-by: Frank Li <Frank.Li@nxp.com>
> >---
> > arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi | 1 -
> > 1 file changed, 1 deletion(-)
> >
> >diff --git a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> >index 880b9a4f32b0846a773dbf9ad30715c84ac2fda6..6d8853d36d930aabb98fb57f49d6153ca6597561 100644
> >--- a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> >+++ b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> >@@ -291,7 +291,6 @@ pcc2: clock-controller@403f0000 {
> > 		smc1: clock-controller@40410000 {
> > 			compatible = "fsl,imx7ulp-smc1";
> > 			reg = <0x40410000 0x1000>;
> >-			#clock-cells = <1>;
>
> Need to fix binding, this is a clock controller and needs #clock-cells to work
> properly.

Thanks, strange no one reference label "smc1"

Frank
>
> There is a driver for this compatible:
> drivers/clk/imx/clk-imx7ulp.c
>
> Regards,
> Peng
>
> > 			clocks = <&scg1 IMX7ULP_CLK_CORE_DIV>,
> > 				 <&scg1 IMX7ULP_CLK_HSRUN_CORE_DIV>;
> > 			clock-names = "divcore", "hsrun_divcore";
> >
> >--
> >2.34.1
> >